Fix intermittent GatewayMonitor unit tests failures

The fake K8s client has a very intermittent concurrency issue where a
notification can be missed if a resource is created while the informer
is starting. This was seen with a GlobalEgressIP so create the
GlobalEgressIP before the controllers are started.

Signed-off-by: Tom Pantelis <[email protected]>

Author: tpantelis

pkg/globalnet/controllers/gateway_monitor_test.go

@@ -65,14 +65,17 @@ var _ = Describe("Endpoint monitoring", func() {
 		})
 
 		Context("", func() {
+			BeforeEach(func() {
+				t.createGlobalEgressIP(newGlobalEgressIP(globalEgressIPName, nil, nil))
+			})
+
 			AfterEach(func() {
 				t.awaitGlobalnetChainsCleared()
 			})
 
 			It("should start the controllers", func() {
 				t.awaitControllersStarted()
 
-				t.createGlobalEgressIP(newGlobalEgressIP(globalEgressIPName, nil, nil))
 				t.awaitGlobalEgressIPStatusAllocated(globalEgressIPName, 1)
 
 				t.createServiceExport(t.createService(newClusterIPService()))
@@ -84,7 +87,12 @@ var _ = Describe("Endpoint monitoring", func() {
 				backendPod := newHeadlessServicePod(service.Name)
 				t.createPod(backendPod)
 				t.createServiceExport(t.createService(service))
-				t.awaitHeadlessGlobalIngressIP(service.Name, backendPod.Name)
+
+				Eventually(func(g Gomega) {
+					gip := t.awaitHeadlessGlobalIngressIP(service.Name, backendPod.Name)
+					g.Expect(gip.Status.AllocatedIP).NotTo(BeEmpty(), resource.ToJSON(gip))
+				}).To(Succeed())
+
 				t.awaitGatewayGlobalIP("")
 			})
 		})