Skip to content

Commit c013471

Browse files
committed
feat: always build before testing
1 parent 2ce2306 commit c013471

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

Diff for: .github/workflows/test.yaml

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: substraitJS test
1+
name: substraitJS
22

33
on: [push, pull_request]
44

@@ -26,9 +26,6 @@ jobs:
2626
- name: Install dependencies
2727
run: npm ci
2828

29-
- name: Build project
30-
run: npm run build
31-
3229
- name: Run tests
3330
run: npm run test
3431

Diff for: .nvmrc

-1
This file was deleted.

Diff for: README.md

+10
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,16 @@ nvm use 18.0.0
4343
4444
substrait -p ../plan.json -o <output path>
4545
```
46+
47+
## Testing
48+
Jest is used for testing the visualization functionality of the library. To run the test, we need
49+
to use `nvm v18.0.0`
50+
```
51+
source ~/.nvm/nvm.sh
52+
nvm use 18.0.0
53+
54+
npm run test
55+
```
4656

4757
## License
4858
[Apache-2.0 license](https://www.apache.org/licenses/LICENSE-2.0)

Diff for: package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"prepare": "npm run clean-proto && npm run proto && npm run transpileProto",
1919
"lint": "eslint '**/*.ts'",
2020
"lint:fix": "npm run lint -- --fix",
21-
"test": "$HOME/.nvm/nvm-exec jest"
21+
"test": "npm run build && jest"
2222
},
2323
"author": "",
2424
"license": "Apache-2.0",

0 commit comments

Comments
 (0)