From fc3fa78a7a1e3c3cf9ba43abdb2cc7fbfc635aae Mon Sep 17 00:00:00 2001
From: Arttu Voutilainen <avoutilainen@palantir.com>
Date: Thu, 27 Jun 2024 09:36:14 +0200
Subject: [PATCH] fix: move back into functions_arithmetic to keep url the same

---
 extensions/functions_aggregate_generic.yaml | 44 ---------------------
 extensions/functions_arithmetic.yaml        | 44 +++++++++++++++++++++
 2 files changed, 44 insertions(+), 44 deletions(-)

diff --git a/extensions/functions_aggregate_generic.yaml b/extensions/functions_aggregate_generic.yaml
index 8835f1909..4d891e9c5 100644
--- a/extensions/functions_aggregate_generic.yaml
+++ b/extensions/functions_aggregate_generic.yaml
@@ -35,47 +35,3 @@ aggregate_functions:
             value: any
         nullability: DECLARED_OUTPUT
         return: any?
-  - name: "first_value"
-    description: >-
-      First value from a group of values.
-
-      The definition of "first" depends on ordering. If ordering is not defined, the returned value may be chosen
-      non-deterministically.
-
-      If `ignore_nulls` is set to `TRUE`, the function will look for the first non-null value.
-      If set to `FALSE`, the function will return the first value it sees, even if null.
-
-      If all values are null or there are no values, returns null.
-    impls:
-      - args:
-          - name: x
-            value: any1
-        options:
-          ignore_nulls:
-            values: [ "TRUE", "FALSE" ]
-        nullability: DECLARED_OUTPUT
-        decomposable: MANY
-        intermediate: any1?
-        return: any1?
-  - name: "last_value"
-    description: >-
-      Last value from a group of values.
-
-      The definition of "last" depends on ordering. If ordering is not defined, the returned value may be chosen
-      non-deterministically.
-
-      If `ignore_nulls` is set to `TRUE`, the function will look for the first non-null value.
-      If set to `FALSE`, the function will return the first value it sees, even if null.
-
-      If all values are null or there are no values, returns null.
-    impls:
-      - args:
-          - name: x
-            value: any1
-        options:
-          ignore_nulls:
-            values: [ "TRUE", "FALSE" ]
-        nullability: DECLARED_OUTPUT
-        decomposable: MANY
-        intermediate: any1?
-        return: any1?
diff --git a/extensions/functions_arithmetic.yaml b/extensions/functions_arithmetic.yaml
index e27e013ff..8e528d123 100644
--- a/extensions/functions_arithmetic.yaml
+++ b/extensions/functions_arithmetic.yaml
@@ -1645,6 +1645,50 @@ aggregate_functions:
         nullability: DECLARED_OUTPUT
         ordered: true
         return: LIST?<any>
+  - name: "first_value"
+    description: >-
+      First value from a group of values.
+
+      The definition of "first" depends on ordering. If ordering is not defined, the returned value may be chosen
+      non-deterministically.
+
+      If `ignore_nulls` is set to `TRUE`, the function will look for the first non-null value.
+      If set to `FALSE`, the function will return the first value it sees, even if null.
+
+      If all values are null or there are no values, returns null.
+    impls:
+      - args:
+          - name: x
+            value: any1
+        options:
+          ignore_nulls:
+            values: [ "TRUE", "FALSE" ]
+        nullability: DECLARED_OUTPUT
+        decomposable: MANY
+        intermediate: any1?
+        return: any1?
+  - name: "last_value"
+    description: >-
+      Last value from a group of values.
+
+      The definition of "last" depends on ordering. If ordering is not defined, the returned value may be chosen
+      non-deterministically.
+
+      If `ignore_nulls` is set to `TRUE`, the function will look for the first non-null value.
+      If set to `FALSE`, the function will return the first value it sees, even if null.
+
+      If all values are null or there are no values, returns null.
+    impls:
+      - args:
+          - name: x
+            value: any1
+        options:
+          ignore_nulls:
+            values: [ "TRUE", "FALSE" ]
+        nullability: DECLARED_OUTPUT
+        decomposable: MANY
+        intermediate: any1?
+        return: any1?
 
 window_functions:
   - name: "row_number"