Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use utils.normalize_doi #150

Open
edsu opened this issue Feb 12, 2025 · 0 comments · May be fixed by #170
Open

Use utils.normalize_doi #150

edsu opened this issue Feb 12, 2025 · 0 comments · May be fixed by #170
Assignees
@edsu

Comments

@edsu
Copy link
Contributor

edsu commented Feb 12, 2025

We have a function for normalizing DOIs:

rialto-airflow/rialto_airflow/utils.py

Lines 83 to 88 in 6bb0110

def normalize_doi(doi):
doi = doi.strip().lower()
doi = doi.replace("https://doi.org/", "").replace("https://dx.doi.org/", "")
doi = re.sub("^doi: ", "", doi)
return doi

But aren't using it here:

It might be worth looking quickly if there are other places.
@edsu edsu self-assigned this Feb 18, 2025
edsu added a commit that referenced this issue Feb 19, 2025
@edsu
Use normalize_doi
c1a0a6a 
For peace of mind it might be good to ensure we are normalize DOIs
consistently when we encounter them, since they are so important for the
data to be joined up correclty.

Fixes #150
@edsu edsu linked a pull request Feb 19, 2025 that will close this issue
Open
edsu added a commit that referenced this issue Feb 19, 2025
@edsu
Use normalize_doi
79d2368 
For peace of mind it might be good to ensure we are normalize DOIs
consistently when we encounter them, since they are so important for the
data to be joined up correctly.

Fixes #150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edsu edsu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use normalize_doi sul-dlss/rialto-airflow
1 participant
@edsu