Skip to content

Commit c2c6341

Browse files
authored
fix(ci): switch to using aws role (#456)
* fix: switch to using aws role * fix: update mirror workflow to use roles * fix: add aws-region config * fix: scope permission to semantic-release job
1 parent a3cc23e commit c2c6341

File tree

2 files changed

+17
-7
lines changed

2 files changed

+17
-7
lines changed

.github/workflows/mirror.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44
workflow_dispatch:
55
inputs:
66
version:
7-
description: "Image tag"
7+
description: 'Image tag'
88
required: true
99
type: string
1010

@@ -15,11 +15,14 @@ jobs:
1515
contents: read
1616
packages: write
1717
steps:
18+
- name: configure aws credentials
19+
uses: aws-actions/configure-aws-credentials@v1
20+
with:
21+
role-to-assume: ${{ secrets.PROD_AWS_ROLE }}
22+
aws-region: us-east-1
1823
- uses: docker/login-action@v2
1924
with:
2025
registry: public.ecr.aws
21-
username: ${{ secrets.PROD_ACCESS_KEY_ID }}
22-
password: ${{ secrets.PROD_SECRET_ACCESS_KEY }}
2326
- uses: docker/login-action@v2
2427
with:
2528
registry: ghcr.io

.github/workflows/release.yml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ jobs:
1010
semantic-release:
1111
name: Release
1212
runs-on: ubuntu-20.04
13+
permissions:
14+
id-token: write # This is required for requesting the JWT from AWS
15+
contents: read # This is required for actions/checkout
1316
outputs:
1417
new-release-published: ${{ steps.semantic-release.outputs.new_release_published }}
1518
new-release-version: ${{ steps.semantic-release.outputs.new_release_version }}
@@ -18,7 +21,13 @@ jobs:
1821

1922
- uses: actions/setup-node@v3
2023
with:
21-
node-version: "16"
24+
node-version: '16'
25+
26+
- name: configure aws credentials
27+
uses: aws-actions/configure-aws-credentials@v1
28+
with:
29+
role-to-assume: ${{ secrets.PROD_AWS_ROLE }}
30+
aws-region: us-east-1
2231

2332
- run: |
2433
npm clean-install
@@ -43,7 +52,7 @@ jobs:
4352

4453
- uses: actions/setup-node@v3
4554
with:
46-
node-version: "16"
55+
node-version: '16'
4756

4857
- name: Prepare release
4958
run: |
@@ -96,8 +105,6 @@ jobs:
96105
uses: docker/login-action@v2
97106
with:
98107
registry: public.ecr.aws
99-
username: ${{ secrets.PROD_ACCESS_KEY_ID }}
100-
password: ${{ secrets.PROD_SECRET_ACCESS_KEY }}
101108

102109
- name: Login to GHCR
103110
uses: docker/login-action@v2

0 commit comments

Comments
 (0)