Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH action to protect from schema changes #297

Closed
prrao87 opened this issue Mar 14, 2024 · 6 comments · Fixed by #516
Closed

Add GH action to protect from schema changes #297

prrao87 opened this issue Mar 14, 2024 · 6 comments · Fixed by #516
Assignees
Labels
vdb comparison Issue/PR related to vdb comparison tool

Comments

@prrao87
Copy link
Contributor

prrao87 commented Mar 14, 2024

Issue

We need to add a GH action to protect against schema changes for the comparison table. Something that informs the user that any changes to the vendor.schema.json file by an external contributor would need to be issued as a separate PR (with no overlap with non-schema related PRs).

This is needed mainly because not all schema changes are necessary, and we'd need to discuss the impact of the schema change before affecting all vendors simultaneously.

@prrao87 prrao87 added the vdb comparison Issue/PR related to vdb comparison tool label Mar 14, 2024
@AruneshSingh
Copy link
Collaborator

On it

@msmygit
Copy link
Contributor

msmygit commented Mar 14, 2024

@prrao87 will you be re-introducing the changes from #295 which was merged earlier and subsequently got reverted?

@prrao87
Copy link
Contributor Author

prrao87 commented Mar 14, 2024

@msmygit that isn't my decision alone to make :). The team here need to discuss and we will keep you posted.

@ClaireSuperlinked
Copy link
Collaborator

@AruneshSingh is there an update on this?

@AruneshSingh
Copy link
Collaborator

Hey, we've started working on the action this week, I'll give a better estimate on when we can deliver it in a day.

Regarding the columns that were added in the PR above (and subsequently removed), we've added it to our list of attributes for us to add. Due to our limited resources we are prioritising attributes/stats that are highly requested and can be filled for most of the vendors. @msmygit It would be great to signal if such attributes are requested by more vendors/help understand the space better.

@AruneshSingh
Copy link
Collaborator

@superlinked/vdb-table-maintainers Launched an action that checks for schema changes and comments on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vdb comparison Issue/PR related to vdb comparison tool
Projects
None yet
4 participants