-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH action to protect from schema changes #297
Comments
On it |
@msmygit that isn't my decision alone to make :). The team here need to discuss and we will keep you posted. |
@AruneshSingh is there an update on this? |
Hey, we've started working on the action this week, I'll give a better estimate on when we can deliver it in a day. Regarding the columns that were added in the PR above (and subsequently removed), we've added it to our list of attributes for us to add. Due to our limited resources we are prioritising attributes/stats that are highly requested and can be filled for most of the vendors. @msmygit It would be great to signal if such attributes are requested by more vendors/help understand the space better. |
@superlinked/vdb-table-maintainers Launched an action that checks for schema changes and comments on the PR. |
Issue
We need to add a GH action to protect against schema changes for the comparison table. Something that informs the user that any changes to the
vendor.schema.json
file by an external contributor would need to be issued as a separate PR (with no overlap with non-schema related PRs).This is needed mainly because not all schema changes are necessary, and we'd need to discuss the impact of the schema change before affecting all vendors simultaneously.
The text was updated successfully, but these errors were encountered: