Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some ideas to improve #2

Open
heyyoyo opened this issue Sep 8, 2015 · 2 comments
Open

Some ideas to improve #2

heyyoyo opened this issue Sep 8, 2015 · 2 comments

Comments

@heyyoyo
Copy link

heyyoyo commented Sep 8, 2015

Really nice job on this Drupal theme !
I think it will be great to add:

Sass globing :

I found this gulp plugin: https://github.com/wiledal/gulp-include which does the job perfectly.

Regular installation:
npm install gulp-include --save-dev

Just need to add:

.pipe($.include()) 

before:

.pipe($.sass({

And then in style.scss we just import files with regex:

For example:

//= include abstraction/**/_*.scss
//= include variables/**/_*.scss
//= include base/**/_*.scss
//= include components/**/_*.scss

Susy grid + breakpoint

Maybe an option in yeoman to add this grid system.

Install those 2 npm plugins:

npm install susy --save-dev
npm install breakpoint-sass --save-dev

And then import those 2 files inside styles.css:

@import "../node_modules/breakpoint-sass/stylesheets/_breakpoint";
@import "../node_modules/susy/sass/_susy";

Uncss

Style testing it, how to include it with Drupal

Critical css

Style testing it, how to include it with Drupal

@supermoos
Copy link
Owner

@heyyoyo good suggestions, I'm currently not able to implement the suggestions just yet (need to get a project that needs it first), that will come eventually, but in the mean time I'd suggest you make a merge request with the changes, then I'll get them in? Last I checked breakpoint-sass had some problems with Libsass though, but maybe it's been solved since I last looked at the project?

@strarsis
Copy link

strarsis commented Dec 2, 2015

And using eyeglass for importing susy + breakpoint sass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants