Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries on file sync failure #290

Open
NanobotZ opened this issue Jan 21, 2022 · 1 comment
Open

Add retries on file sync failure #290

NanobotZ opened this issue Jan 21, 2022 · 1 comment
Labels
enhancement regression Behavior that was working in previous versions
Milestone

Comments

@NanobotZ
Copy link

NanobotZ commented Jan 21, 2022

Serversync Version:

4.2.0

Minecraft Version:

doesn't matter

Issue:

According to this line, it doesn't matter whether file updates are run successfully or not, the program doesn't inform the user that something went wrong while processing nor it doesn't try to retry the update action again later, as the boolean value returned by this function isn't handled anywhere.

server.updateIndividualFile(action, progressConsumer);

I don't think this is a good behavior, as client users with spotty internet connection (I know two that run into this problem) may not even notice that something went wrong while syncing with the server, especially if running in no-GUI mode.

@rheimus rheimus changed the title Failed file updates are skipped Add retries on file sync failure Jan 22, 2022
@rheimus
Copy link
Collaborator

rheimus commented Jan 22, 2022

Yep, retries ended up being removed at some point. Makes sense to add them back in with some sort of exit handling/ui for it as well.

@rheimus rheimus added the regression Behavior that was working in previous versions label Jan 22, 2022
@rheimus rheimus added this to the future milestone Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement regression Behavior that was working in previous versions
Projects
None yet
Development

No branches or pull requests

2 participants