From a7a5a30c2cd00d3ff0e8bef84768a54fed880472 Mon Sep 17 00:00:00 2001 From: David Bottiau Date: Thu, 28 Nov 2024 13:12:07 +0100 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F=20avoid=20registering=20Http?= =?UTF-8?q?Client=20if=20not=20using=20http(s)=20protocol=20(#147)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../ServiceCollectionExtensions.cs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/SurrealDb.Net/Extensions/DependencyInjection/ServiceCollectionExtensions.cs b/SurrealDb.Net/Extensions/DependencyInjection/ServiceCollectionExtensions.cs index 24de5321..10fc122e 100644 --- a/SurrealDb.Net/Extensions/DependencyInjection/ServiceCollectionExtensions.cs +++ b/SurrealDb.Net/Extensions/DependencyInjection/ServiceCollectionExtensions.cs @@ -133,7 +133,11 @@ public static SurrealDbBuilder AddSurreal( if (configuration.Endpoint is null) throw new ArgumentNullException(nameof(configuration), "The endpoint is required."); - RegisterHttpClient(services, configuration.Endpoint); + bool shouldRegisterHttpClient = new Uri(configuration.Endpoint).Scheme is "http" or "https"; + if (shouldRegisterHttpClient) + { + RegisterHttpClient(services, configuration.Endpoint); + } var classClientType = typeof(SurrealDbClient); var interfaceClientType = typeof(ISurrealDbClient); @@ -195,7 +199,7 @@ private static void RegisterSurrealDbClient( return new SurrealDbClient( configuration, serviceProvider, - serviceProvider.GetRequiredService(), + serviceProvider.GetService(), configureCborOptions, serviceProvider.GetService() ); @@ -210,7 +214,7 @@ private static void RegisterSurrealDbClient( return new SurrealDbClient( configuration, serviceProvider, - serviceProvider.GetRequiredService(), + serviceProvider.GetService(), configureCborOptions, serviceProvider.GetService() ); @@ -225,7 +229,7 @@ private static void RegisterSurrealDbClient( return new SurrealDbClient( configuration, serviceProvider, - serviceProvider.GetRequiredService(), + serviceProvider.GetService(), configureCborOptions, serviceProvider.GetService() );