Merge PR linkedin#2793 ack-timeout clamp into PR linkedin#2794

Author: sushantmane

clients/da-vinci-client/src/main/java/com/linkedin/davinci/config/VeniceServerConfig.java

@@ -1282,8 +1282,16 @@ public VeniceServerConfig(VeniceProperties serverProperties, Map<String, Map<Str
         serverProperties.getBoolean(SERVER_LEADER_HANDOVER_EMIT_STEPDOWN_STAMP, false);
     this.leaderHandoverConsumeStepDownStamp =
         serverProperties.getBoolean(SERVER_LEADER_HANDOVER_CONSUME_STEPDOWN_STAMP, false);
+    /*
+     * Clamp to a non-negative value at read time so that the stamp emit path can call
+     * CompletableFuture#get(long, TimeUnit) unconditionally without having to defend against a
+     * misconfigured negative timeout (which would otherwise either return immediately or, in
+     * some JDK versions, throw IllegalArgumentException — neither is desirable in the demotion
+     * handler). A zero value still works: get(0, MILLISECONDS) attempts a no-wait poll and
+     * times out immediately if the produce hasn't acked, which is the operator's choice.
+     */
     this.leaderHandoverEmitStepDownStampAckTimeoutMs =
-        serverProperties.getLong(SERVER_LEADER_HANDOVER_EMIT_STEPDOWN_STAMP_ACK_TIMEOUT_MS, 1000L);
+        Math.max(0L, serverProperties.getLong(SERVER_LEADER_HANDOVER_EMIT_STEPDOWN_STAMP_ACK_TIMEOUT_MS, 1000L));
     this.serverIngestionInfoLogLineLimit = serverProperties.getInt(SERVER_INGESTION_INFO_LOG_LINE_LIMIT, 20);
     this.parallelResourceShutdownEnabled =
         serverProperties.getBoolean(SERVER_PARALLEL_RESOURCE_SHUTDOWN_ENABLED, false);