From c05f9e9ae0974d5a6ee8538c603cff8decafac58 Mon Sep 17 00:00:00 2001 From: physsi07 Date: Sat, 5 Oct 2019 01:56:33 -0400 Subject: [PATCH] issue: #7 | Fixing flake8 bug, adding flake8 to requirements.txt & modifying the makefile --- makefile | 10 ++++++++-- tests/unit/constants_test.py | 2 +- tests/utils/requirements.txt | 4 +--- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/makefile b/makefile index 85da871..4089930 100644 --- a/makefile +++ b/makefile @@ -17,6 +17,9 @@ preInstall: pip install -U pytest pytest --version +.PHONY: lint +lint: + .PHONY: test test: .cleanCoverage pytest $(TEST_DIR)/unit @@ -35,7 +38,10 @@ openReport: .cleanCoverage .PHONY: help help: - @echo 'createVirtualenv - ' - @echo 'preInstall - ' + @echo '==================================== HELP ====================================' + @echo 'createVirtualenv - creates a virtualenv' + @echo 'preInstall - install all run pre requisites to run tests and coverage report' @echo 'test - run unit tests on all Python files' @echo 'openReport - check code coverage of all Python files' + @echo 'lint - run pylint and flake8 on all your Python files' + @echo '' diff --git a/tests/unit/constants_test.py b/tests/unit/constants_test.py index 0d6ec15..d2dce1d 100644 --- a/tests/unit/constants_test.py +++ b/tests/unit/constants_test.py @@ -3,6 +3,6 @@ def test_NoValue_object(): """ - Should ensure the NoValue property is an object + Should ensure the NoValue property is an object """ assert type(constants.NoValue) == object diff --git a/tests/utils/requirements.txt b/tests/utils/requirements.txt index e6446c4..305bf1f 100644 --- a/tests/utils/requirements.txt +++ b/tests/utils/requirements.txt @@ -2,6 +2,4 @@ aioredis==1.3.0 coverage==4.5.4 isort==4.3.21 black==19.3b0 -appdirs==1.4.3 -click==7.0 -toml==0.10.0 +flake8==3.7.8