Preflight issues don't update on remote function form during subsequent submissions

[dr-starchildren]

Describe the bug

When using preflight() on a remote function form, we want to be able to access the results, so we can show a toast message (or other effect). While, we can check the form using onsubmit and tick(), there's a bug after an error has been added to the form's issues.

For the initial submission if we enter correct data or incorrect data, everything works as expected. However, if we had entered incorrect data the first time, then all subsequent submissions still have 'issues' on the form, even when the data is valid.

For example:
First entry: a (invalid)
Second entry: abc (valid)

Using .validate() doesn't resolve the issue. If using an .enhance(), the behavior occurs there as well.

Expected behavior: When using preflight if incorrect data is entered the first time, on a future submission where the data is valid the form should submit correctly.
Actual Behavior: After having incorrect data on the form, the 'issues()' does not update for preflight.

Initial discord discussion:
https://discord.com/channels/457912077277855764/1460579385970000037

Reproduction

https://stackblitz.com/edit/sveltejs-kit-template-default-fbcc3bee?file=src%2Froutes%2F%2Bpage.svelte

Logs

System Info

https://stackblitz.com

Severity

annoyance

Additional Information

No response

[Rishab49]

The reason of this behaviour is that whenever we are having any issue in validation we are setting the raw_issue to current issues but in subsequent tries even if we donot have any issue after validation, we are not resetting the raw_issue to an empty array, hence validated data without any issue is also showing issue.

kit/packages/kit/src/runtime/client/remote-functions/form.svelte.js

Lines 115 to 123 in 391c6f7

	if (validated?.issues) {
	raw_issues = merge_with_server_issues(
	form_data,
	raw_issues,
	validated.issues.map((issue) => normalize_issue(issue, false))
	);
	return;
	}

I made the following changes and it is working fine for me.

if (validated?.issues) {
				raw_issues = merge_with_server_issues(
					form_data,
					raw_issues,
					validated.issues.map((issue) => normalize_issue(issue, false))
				);
				return;
} else{

   // setting raw_issues to empty
	raw_issues = [];
}