Skip to content

Commit 10a218c

Browse files
authored
chore: migrate eslint config (#598)
1 parent 1bf4a33 commit 10a218c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+635
-750
lines changed

.devcontainer/devcontainer.json

+18-21
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,27 @@
11
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
22
// https://github.com/microsoft/vscode-dev-containers/tree/v0.209.6/containers/javascript-node
33
{
4-
"name": "Node.js",
5-
"build": {
6-
"dockerfile": "Dockerfile",
7-
// Update 'VARIANT' to pick a Node version: 16, 14, 12.
8-
// Append -bullseye or -buster to pin to an OS version.
9-
// Use -bullseye variants on local arm64/Apple Silicon.
10-
"args": { "VARIANT": "16-bullseye" }
11-
},
4+
"name": "Node.js",
5+
"build": {
6+
"dockerfile": "Dockerfile",
7+
// Update 'VARIANT' to pick a Node version: 16, 14, 12.
8+
// Append -bullseye or -buster to pin to an OS version.
9+
// Use -bullseye variants on local arm64/Apple Silicon.
10+
"args": { "VARIANT": "16-bullseye" }
11+
},
1212

13-
// Set *default* container specific settings.json values on container create.
14-
"settings": {},
13+
// Set *default* container specific settings.json values on container create.
14+
"settings": {},
1515

16-
// Add the IDs of extensions you want installed when the container is created.
17-
"extensions": [
18-
"dbaeumer.vscode-eslint",
19-
"svelte.svelte-vscode"
20-
],
16+
// Add the IDs of extensions you want installed when the container is created.
17+
"extensions": ["dbaeumer.vscode-eslint", "svelte.svelte-vscode"],
2118

22-
// Use 'forwardPorts' to make a list of ports inside the container available locally.
23-
// "forwardPorts": [],
19+
// Use 'forwardPorts' to make a list of ports inside the container available locally.
20+
// "forwardPorts": [],
2421

25-
// Use 'postCreateCommand' to run commands after the container is created.
26-
"postCreateCommand": "pnpm install",
22+
// Use 'postCreateCommand' to run commands after the container is created.
23+
"postCreateCommand": "pnpm install",
2724

28-
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
29-
"remoteUser": "node"
25+
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
26+
"remoteUser": "node"
3027
}

.eslintignore

-18
This file was deleted.

.eslintrc-for-playground.js

-16
This file was deleted.

.eslintrc.js

-88
This file was deleted.

.github/workflows/NodeCI.yml

+1-41
Original file line numberDiff line numberDiff line change
@@ -77,47 +77,7 @@ jobs:
7777
node-version: ${{ matrix.node-version }}
7878
- name: Install Svelte v3
7979
run: |+
80-
pnpm install -D svelte@3 @typescript-eslint/parser@5 @typescript-eslint/eslint-plugin@5
81-
rm -rf node_modules
82-
- name: Install Packages
83-
run: pnpm install
84-
- name: Test
85-
run: pnpm run test
86-
test-for-ts-eslint-v5:
87-
runs-on: ubuntu-latest
88-
strategy:
89-
matrix:
90-
node-version: [18.x]
91-
steps:
92-
- uses: actions/checkout@v4
93-
- uses: pnpm/action-setup@v2
94-
- name: Use Node.js ${{ matrix.node-version }}
95-
uses: actions/setup-node@v4
96-
with:
97-
node-version: ${{ matrix.node-version }}
98-
- name: Install @typescript-eslint v5
99-
run: |+
100-
pnpm install -D @typescript-eslint/parser@5 @typescript-eslint/eslint-plugin@5
101-
rm -rf node_modules
102-
- name: Install Packages
103-
run: pnpm install
104-
- name: Test
105-
run: pnpm run test
106-
test-for-eslint-v7:
107-
runs-on: ubuntu-latest
108-
strategy:
109-
matrix:
110-
node-version: [18.x]
111-
steps:
112-
- uses: actions/checkout@v4
113-
- uses: pnpm/action-setup@v2
114-
- name: Use Node.js ${{ matrix.node-version }}
115-
uses: actions/setup-node@v4
116-
with:
117-
node-version: ${{ matrix.node-version }}
118-
- name: Install eslint v7
119-
run: |+
120-
pnpm install -D eslint@7 svelte@3 @typescript-eslint/parser@5 @typescript-eslint/eslint-plugin@5
80+
pnpm install -D svelte@3
12181
rm -rf node_modules
12282
- name: Install Packages
12383
run: pnpm install

.vscode/settings.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@
1515
"editor.codeActionsOnSave": {
1616
"source.fixAll.eslint": "explicit"
1717
},
18-
"vetur.validation.template": false
18+
"eslint.enable": true
1919
}

benchmark/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// eslint-disable-next-line eslint-comments/disable-enable-pair -- ignore
1+
// eslint-disable-next-line @eslint-community/eslint-comments/disable-enable-pair -- ignore
22
/* eslint-disable no-console -- ignore */
33
import * as Benchmark from "benchmark";
44
import fs from "fs";

0 commit comments

Comments
 (0)