Skip to content

Commit ed8a19c

Browse files
authored
fix: don't try to resolve internal node modules via package.json svelte field (#266)
* fix: don't try to resolve internal node modules via package.json svelte field * chore: merge imports
1 parent 5786dab commit ed8a19c

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

.changeset/chatty-trees-sell.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sveltejs/vite-plugin-svelte': patch
3+
---
4+
5+
don't try to resolve node internal modules via package.json svelte field

packages/vite-plugin-svelte/src/utils/resolve.ts

+11-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import path from 'path';
2-
import { createRequire } from 'module';
2+
import { builtinModules, createRequire } from 'module';
33
import { is_common_without_svelte_field, resolveDependencyData } from './dependencies';
44
import { VitePluginSvelteCache } from './vite-plugin-svelte-cache';
55

@@ -8,7 +8,12 @@ export function resolveViaPackageJsonSvelte(
88
importer: string | undefined,
99
cache: VitePluginSvelteCache
1010
): string | void {
11-
if (importer && isBareImport(importee) && !is_common_without_svelte_field(importee)) {
11+
if (
12+
importer &&
13+
isBareImport(importee) &&
14+
!isNodeInternal(importee) &&
15+
!is_common_without_svelte_field(importee)
16+
) {
1217
const cached = cache.getResolvedSvelteField(importee, importer);
1318
if (cached) {
1419
return cached;
@@ -28,6 +33,10 @@ export function resolveViaPackageJsonSvelte(
2833
}
2934
}
3035

36+
function isNodeInternal(importee: string) {
37+
return importee.startsWith('node:') || builtinModules.includes(importee);
38+
}
39+
3140
function isBareImport(importee: string): boolean {
3241
if (
3342
!importee ||

0 commit comments

Comments
 (0)