Merge pull request #18 from svycka/fix-deprecated-flush

fixed: Calling Doctrine\ORM\EntityManager::flush() with any arguments…

Author: svycka

CHANGELOG.md

@@ -11,7 +11,7 @@ All Notable changes to `svycka/sv-settings` will be documented in this file
 - Nothing
 
 ### Fixed
-- Nothing
+- [BC Break] Will call flush() on Doctrine entityManager without specific entity because it is deprecated
 
 ### Removed
 - Nothing

src/Storage/DoctrineStorage.php

@@ -64,7 +64,7 @@ public function set(CollectionInterface $collection, $identifier, $name, $value)
         $setting->setValue($value);
 
         $this->entityManager->persist($setting);
-        $this->entityManager->flush($setting);
+        $this->entityManager->flush();
     }
 
     /**

tests/Settings/Storage/DoctrineStorageTest.php

@@ -55,7 +55,7 @@ function (SettingInterface $value) {
         );
         $entityManager = $this->prophesize(EntityManagerInterface::class);
         $entityManager->persist($entity)->shouldBeCalled();
-        $entityManager->flush($entity)->shouldBeCalled();
+        $entityManager->flush()->shouldBeCalled();
         $repository = $this->prophesize(ObjectRepository::class);
         $repository->findOneBy([
             'collection' => $this->collection->getOptions()->getName(),
@@ -74,7 +74,7 @@ public function testCanUpdate()
         $setting->setValue($value = 'F')->shouldBeCalled();
         $entityManager = $this->prophesize(EntityManagerInterface::class);
         $entityManager->persist($setting->reveal())->shouldBeCalled();
-        $entityManager->flush($setting->reveal())->shouldBeCalled();
+        $entityManager->flush()->shouldBeCalled();
 
         $repository = $this->prophesize(ObjectRepository::class);
         $repository->findOneBy([