[PHP] Improve duplicated validation logic (#7954)

* Improve duplicated validation logic

* Update the samples

Author: ackintosh

modules/swagger-codegen/src/main/resources/php/model_generic.mustache

@@ -259,65 +259,7 @@ class {{classname}} {{#parentSchema}}extends {{{parent}}} {{/parentSchema}}{{^pa
      */
     public function valid()
     {
-        {{#parent}}
-        if (!parent::valid()) {
-            return false;
-        }
-        {{/parent}}
-
-        {{#vars}}
-        {{#required}}
-        if ($this->container['{{name}}'] === null) {
-            return false;
-        }
-        {{/required}}
-        {{#isEnum}}
-        {{^isContainer}}
-        $allowedValues = $this->{{getter}}AllowableValues();
-        if (!is_null($this->container['{{name}}']) && !in_array($this->container['{{name}}'], $allowedValues, true)) {
-            return false;
-        }
-        {{/isContainer}}
-        {{/isEnum}}
-        {{#hasValidation}}
-        {{#maxLength}}
-        if (mb_strlen($this->container['{{name}}']) > {{maxLength}}) {
-            return false;
-        }
-        {{/maxLength}}
-        {{#minLength}}
-        if (mb_strlen($this->container['{{name}}']) < {{minLength}}) {
-            return false;
-        }
-        {{/minLength}}
-        {{#maximum}}
-        if ($this->container['{{name}}'] >{{#exclusiveMaximum}}={{/exclusiveMaximum}} {{maximum}}) {
-            return false;
-        }
-        {{/maximum}}
-        {{#minimum}}
-        if ($this->container['{{name}}'] <{{#exclusiveMinimum}}={{/exclusiveMinimum}} {{minimum}}) {
-            return false;
-        }
-        {{/minimum}}
-        {{#pattern}}
-        if (!preg_match("{{{pattern}}}", $this->container['{{name}}'])) {
-            return false;
-        }
-        {{/pattern}}
-        {{#maxItems}}
-        if (count($this->container['{{name}}']) > {{maxItems}}) {
-            return false;
-        }
-        {{/maxItems}}
-        {{#minItems}}
-        if (count($this->container['{{name}}']) < {{minItems}}) {
-            return false;
-        }
-        {{/minItems}}
-        {{/hasValidation}}
-        {{/vars}}
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }
 
     {{#vars}}

samples/client/petstore-security-test/php/SwaggerClient-php/lib/Model/ModelReturn.php

@@ -201,8 +201,7 @@ public function listInvalidProperties()
      */
     public function valid()
     {
-
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }
 
 

samples/client/petstore/php/SwaggerClient-php/lib/Model/AdditionalPropertiesClass.php

@@ -206,8 +206,7 @@ public function listInvalidProperties()
      */
     public function valid()
     {
-
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }
 
 

samples/client/petstore/php/SwaggerClient-php/lib/Model/Animal.php

@@ -213,11 +213,7 @@ public function listInvalidProperties()
      */
     public function valid()
     {
-
-        if ($this->container['class_name'] === null) {
-            return false;
-        }
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }
 
 

samples/client/petstore/php/SwaggerClient-php/lib/Model/AnimalFarm.php

@@ -199,11 +199,7 @@ public function listInvalidProperties()
      */
     public function valid()
     {
-        if (!parent::valid()) {
-            return false;
-        }
-
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }
 
     /**

samples/client/petstore/php/SwaggerClient-php/lib/Model/ApiResponse.php

@@ -212,8 +212,7 @@ public function listInvalidProperties()
      */
     public function valid()
     {
-
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }
 
 

samples/client/petstore/php/SwaggerClient-php/lib/Model/ArrayOfArrayOfNumberOnly.php

@@ -200,8 +200,7 @@ public function listInvalidProperties()
      */
     public function valid()
     {
-
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }
 
 

samples/client/petstore/php/SwaggerClient-php/lib/Model/ArrayOfNumberOnly.php

@@ -200,8 +200,7 @@ public function listInvalidProperties()
      */
     public function valid()
     {
-
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }
 
 

samples/client/petstore/php/SwaggerClient-php/lib/Model/ArrayTest.php

@@ -212,8 +212,7 @@ public function listInvalidProperties()
      */
     public function valid()
     {
-
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }
 
 

samples/client/petstore/php/SwaggerClient-php/lib/Model/Capitalization.php

@@ -230,8 +230,7 @@ public function listInvalidProperties()
      */
     public function valid()
     {
-
-        return true;
+        return count($this->listInvalidProperties()) === 0;
     }