Prove JsonPointer::remove() doesn't handle sequential arrays correctly

outdooracorn · outdooracorn · commit c7a5859eada4 · 2023-10-23T17:23:31.000+01:00
Bug: T349483
diff --git a/tests/src/JsonPointerTest.php b/tests/src/JsonPointerTest.php
@@ -96,6 +96,13 @@ public function testGetSetDeleteObject()
         $this->assertEquals(null, $s->one->two);
     }
 
+    public function testSequentialArrayIsPreserved()
+    {
+		$json = [ 'l1' => [ 0 => 'foo', 1 => 'bar', 2 => 'baz' ] ];
+		JsonPointer::remove($json, ['l1', '1'], JsonPointer::TOLERATE_ASSOCIATIVE_ARRAYS);
+		$this->assertSame('{"l1":["foo","baz"]}', json_encode($json));
+    }
+
 }
 
 class Sample

Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,13 @@ public function testGetSetDeleteObject()`
`96`	`96`	`$this->assertEquals(null, $s->one->two);`
`97`	`97`	`}`
`98`	`98`
	`99`	`+ public function testSequentialArrayIsPreserved()`
	`100`	`+ {`
	`101`	`+ $json = [ 'l1' => [ 0 => 'foo', 1 => 'bar', 2 => 'baz' ] ];`
	`102`	`+ JsonPointer::remove($json, ['l1', '1'], JsonPointer::TOLERATE_ASSOCIATIVE_ARRAYS);`
	`103`	`+ $this->assertSame('{"l1":["foo","baz"]}', json_encode($json));`
	`104`	`+ }`
	`105`	`+`
`99`	`106`	`}`
`100`	`107`
`101`	`108`	`class Sample`