Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Include failed operation in Exception #45

Open
Richard87 opened this issue Nov 19, 2021 · 2 comments
Open

Enhancement: Include failed operation in Exception #45

Richard87 opened this issue Nov 19, 2021 · 2 comments

Comments

@Richard87
Copy link

Hi!

Thanks for an awesome project!

We have som Diffs with a lot of operations in each patch, and the exception can be a little hard to troubleshoot.

Would you be interested in a PR that includes the failed operation in the exception?
@vearutop
Copy link
Member

Hi, thank you for using this library.

Such PR would definitely be a valuable contribution, please send!

@jakobw jakobw mentioned this issue Oct 13, 2022
Closed
@jakobw
Copy link
Contributor

jakobw commented Oct 21, 2022

If I'm not mistaken this is done in #57. All specific exceptions we added there contain the failed operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakobw @vearutop @Richard87