Remove unnecessary condition in _safe_flags function (#132)

reimerix · web-flow · commit 2deb089e3717 · 2024-12-04T11:39:02.000+01:00
## Description Cover the following topics in the description: - [ ] Rational - [ ] Context - [ ] Design notes ## Jira Reference Link to a Jira ticket: - [ ] https://swift-nav.atlassian.net/browse/BOARD-123
diff --git a/clang_tidy/clang_tidy.bzl b/clang_tidy/clang_tidy.bzl
@@ -126,7 +126,7 @@ def _safe_flags(flags):
         "-Wno-stringop-overflow",
     ]
 
-    return [flag for flag in flags if flag not in unsupported_flags and not flag.startswith("--sysroot") and not "-std=" in flag]
+    return [flag for flag in flags if flag not in unsupported_flags and not flag.startswith("--sysroot")]
 
 def _replace_gendir(flags, ctx):
     return [flag.replace("$(GENDIR)", ctx.genfiles_dir.path) for flag in flags]

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ def _safe_flags(flags):`
`126`	`126`	`"-Wno-stringop-overflow",`
`127`	`127`	`]`
`128`	`128`
`129`		`- return [flag for flag in flags if flag not in unsupported_flags and not flag.startswith("--sysroot") and not "-std=" in flag]`
	`129`	`+ return [flag for flag in flags if flag not in unsupported_flags and not flag.startswith("--sysroot")]`
`130`	`130`
`131`	`131`	`def _replace_gendir(flags, ctx):`
`132`	`132`	`return [flag.replace("$(GENDIR)", ctx.genfiles_dir.path) for flag in flags]`