Skip to content

Commit 62c06d4

Browse files
authored
Remove tests relying on OS-dependent behaviour (#703)
Motivation URL parsing has changed in macOS Sonoma and associated releases. Our tests were reliant on the old behaviour. The behaviour is controlled by the OS on which the program was linked, which makes it impossible for us to programmatically work out which result we should see. The affected tests are not actually useful, we don't really care how the URLs parse, so we can safely just remove them. Modifications Remove the affected tests. Result Tests pass!
1 parent e1c85a6 commit 62c06d4

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

Diff for: Tests/AsyncHTTPClientTests/HTTPClientTests.swift

-6
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,6 @@ final class HTTPClientTests: XCTestCaseHTTPClientTestsBaseClass {
155155
XCTAssertEqual(url.path, "/file/path")
156156
XCTAssertEqual(url.absoluteString, "https+unix://%2Ftmp%2Ffile%20with%20spaces%E3%81%A8%E6%BC%A2%E5%AD%97/file/path")
157157
}
158-
159-
let url9 = URL(httpURLWithSocketPath: "/tmp/file", uri: " ")
160-
XCTAssertNil(url9)
161-
162-
let url10 = URL(httpsURLWithSocketPath: "/tmp/file", uri: " ")
163-
XCTAssertNil(url10)
164158
}
165159

166160
func testBadUnixWithBaseURL() {

0 commit comments

Comments
 (0)