Skip to content

Commit f2aef45

Browse files
authored
fix test faling with NIOTS (#257)
1 parent 785ced5 commit f2aef45

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

Diff for: Tests/AsyncHTTPClientTests/HTTPClientInternalTests.swift

+7-1
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,23 @@ class HTTPClientInternalTests: XCTestCase {
2323
typealias Request = HTTPClient.Request
2424
typealias Task = HTTPClient.Task
2525

26+
var serverGroup: EventLoopGroup!
2627
var clientGroup: EventLoopGroup!
2728

2829
override func setUp() {
2930
XCTAssertNil(self.clientGroup)
31+
XCTAssertNil(self.serverGroup)
32+
self.serverGroup = MultiThreadedEventLoopGroup(numberOfThreads: 1)
3033
self.clientGroup = getDefaultEventLoopGroup(numberOfThreads: 1)
3134
}
3235

3336
override func tearDown() {
37+
XCTAssertNotNil(self.serverGroup)
38+
XCTAssertNoThrow(try self.serverGroup.syncShutdownGracefully())
3439
XCTAssertNotNil(self.clientGroup)
3540
XCTAssertNoThrow(try self.clientGroup.syncShutdownGracefully())
3641
self.clientGroup = nil
42+
self.serverGroup = nil
3743
}
3844

3945
func testHTTPPartsHandler() throws {
@@ -833,7 +839,7 @@ class HTTPClientInternalTests: XCTestCase {
833839
}
834840

835841
func testUncleanCloseThrows() {
836-
let server = NIOHTTP1TestServer(group: self.clientGroup)
842+
let server = NIOHTTP1TestServer(group: self.serverGroup)
837843
defer {
838844
XCTAssertNoThrow(try server.stop())
839845
}

Diff for: Tests/AsyncHTTPClientTests/HTTPClientTests.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -2031,7 +2031,7 @@ class HTTPClientTests: XCTestCase {
20312031
let second = elg.next()
20322032
XCTAssertFalse(first === second)
20332033

2034-
let httpServer = NIOHTTP1TestServer(group: first)
2034+
let httpServer = NIOHTTP1TestServer(group: self.serverGroup)
20352035
let httpClient = HTTPClient(eventLoopGroupProvider: .shared(first))
20362036
defer {
20372037
XCTAssertNoThrow(try httpClient.syncShutdown())

0 commit comments

Comments
 (0)