Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AHC seems to return from its syncClose before it's actually done #220

Closed
weissi opened this issue May 19, 2020 · 1 comment
Closed

AHC seems to return from its syncClose before it's actually done #220

weissi opened this issue May 19, 2020 · 1 comment
Assignees
Labels
kind/bug Feature doesn't work as expected.
Milestone

Comments

@weissi
Copy link
Contributor

weissi commented May 19, 2020

When running testUploadsReallyStream from #219, I often get this message printed to the command line:

ERROR: Cannot schedule tasks on an EventLoop that has already shut down. This will be upgraded to a forced crash in future SwiftNIO versions.

But I do wait for everything to shut down.

I suspect that AHC isn't actually 100% done after its syncShutdown method returns. There might be some still active Channels? Unsure, but there's definitely a bug in either AHC or NIO.

NIO issues this printout (will be upgraded to crash in the future), if the ELG has been shutdown and after that has happened, more work gets scheduled (which is illegal because it can never run).

@artemredkin artemredkin self-assigned this May 20, 2020
@artemredkin artemredkin added this to the 1.2.0 milestone May 20, 2020
@artemredkin artemredkin added the kind/bug Feature doesn't work as expected. label May 20, 2020
@artemredkin
Copy link
Collaborator

Closed by #221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Feature doesn't work as expected.
Projects
None yet
Development

No branches or pull requests

2 participants