Skip to content

Commit 344a60e

Browse files
committed
ignore-unacceptable-language inline
1 parent 398a22f commit 344a60e

File tree

4 files changed

+7
-10
lines changed

4 files changed

+7
-10
lines changed

.github/workflows/pull_request.yml

-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ jobs:
1010
uses: apple/swift-nio/.github/workflows/soundness.yml@main
1111
with:
1212
license_header_check_project_name: "SwiftAWSLambdaRuntime"
13-
# remove "kill killed" from the default list for now
14-
unacceptable_language_check_word_list:
15-
"blacklist whitelist slave master sane sanity insane insanity killing hang hung hanged hanging"
1613

1714
unit-tests:
1815
name: Unit tests

Sources/AWSLambdaRuntimeCore/Utils.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ internal enum Signal: Int32 {
5353
case INT = 2
5454
case QUIT = 3
5555
case ABRT = 6
56-
case KILL = 9
56+
case KILL = 9 // ignore-unacceptable-language
5757
case ALRM = 14
5858
case TERM = 15
5959
}

Tests/AWSLambdaRuntimeCoreTests/LambdaTest.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ class LambdaTest: XCTestCase {
9393
// we need to schedule the signal before we start the long running `Lambda.run`, since
9494
// `Lambda.run` will block the main thread.
9595
usleep(100_000)
96-
kill(getpid(), signal.rawValue)
96+
kill(getpid(), signal.rawValue) // ignore-unacceptable-language
9797
}
9898
let result = Lambda.run(configuration: configuration, handlerType: EchoHandler.self)
9999

scripts/performance_test.sh

+5-5
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ swift build --package-path Examples/Echo -c release -Xswiftc -g
3131
swift build --package-path Examples/JSON -c release -Xswiftc -g
3232

3333
cleanup() {
34-
kill -9 $server_pid
34+
kill -9 $server_pid # ignore-unacceptable-language
3535
}
3636

3737
trap "cleanup" ERR
@@ -47,12 +47,12 @@ results=()
4747
export MODE=string
4848

4949
# start (fork) mock server
50-
pkill -9 MockServer && echo "killed previous servers" && sleep 1
50+
pkill -9 MockServer && echo "killed previous servers" && sleep 1 # ignore-unacceptable-language
5151
echo "starting server in $MODE mode"
5252
(./.build/release/MockServer) &
5353
server_pid=$!
5454
sleep 1
55-
kill -0 $server_pid # check server is alive
55+
kill -0 $server_pid # check server is alive # ignore-unacceptable-language
5656

5757
# cold start
5858
echo "running $MODE mode cold test"
@@ -85,12 +85,12 @@ results+=( "$MODE, warm: $avg_warm (ns)" )
8585
export MODE=json
8686

8787
# start (fork) mock server
88-
pkill -9 MockServer && echo "killed previous servers" && sleep 1
88+
pkill -9 MockServer && echo "killed previous servers" && sleep 1 # ignore-unacceptable-language
8989
echo "starting server in $MODE mode"
9090
(./.build/release/MockServer) &
9191
server_pid=$!
9292
sleep 1
93-
kill -0 $server_pid # check server is alive
93+
kill -0 $server_pid # check server is alive # ignore-unacceptable-language
9494

9595
# cold start
9696
echo "running $MODE mode cold test"

0 commit comments

Comments
 (0)