Create file URLs for bundle files in TestFileSystem (#661)

Also, create file URL for baseURL fallback for DiagnosticConsoleWriter

Author: d-ronnqvist

Sources/SwiftDocCUtilities/Action/Actions/Convert/ConvertAction.swift

@@ -152,7 +152,7 @@ public struct ConvertAction: Action, RecreatingContext {
         engine.add(
             DiagnosticConsoleWriter(
                 formattingOptions: formattingOptions,
-                baseURL: documentationBundleURL ?? URL(string: fileManager.currentDirectoryPath)
+                baseURL: documentationBundleURL ?? URL(fileURLWithPath: fileManager.currentDirectoryPath)
             )
         )
         if let diagnosticFilePath = diagnosticFilePath {

Tests/SwiftDocCUtilitiesTests/Utility/TestFileSystem.swift

@@ -82,7 +82,7 @@ class TestFileSystem: FileManagerProtocol, DocumentationWorkspaceDataProvider {
         for folder in folders {
             let files = try addFolder(folder)
             if let info = folder.recursiveContent.mapFirst(where: { $0 as? InfoPlist }) {
-                let files = files.filter({ $0.hasPrefix(folder.absoluteURL.path) }).compactMap({ URL(string: $0) })
+                let files = files.filter({ $0.hasPrefix(folder.absoluteURL.path) }).compactMap({ URL(fileURLWithPath: $0) })
 
                 let markupFiles = files.filter({ DocumentationBundleFileTypes.isMarkupFile($0) })
                 let miscFiles = files.filter({ !DocumentationBundleFileTypes.isMarkupFile($0) })

Tests/SwiftDocCUtilitiesTests/Utility/TestFileSystemTests.swift

@@ -259,4 +259,29 @@ class TestFileSystemTests: XCTestCase {
         XCTAssertFalse(fs.contentsEqual(atPath: "/main/test.txt", andPath: "/main/notclone.txt"))
         XCTAssertFalse(fs.contentsEqual(atPath: "/main/test.txt", andPath: "/main/missing.txt"))
     }
+    
+    func testBundleUsesFileURLs() throws {
+        let emptySymbolGraphData = try JSONEncoder().encode(makeSymbolGraph(moduleName: "Something"))
+        
+        // A docc catalog with an article, a resource, an Info.plist file, and a symbol graph file
+        let folders = Folder(name: "something.docc", content: [
+            TextFile(name: "article.md", utf8Content: ""),
+            DataFile(name: "image.png", data: Data()),
+            InfoPlist(displayName: "unit-test", identifier: "com.example"),
+            DataFile(name: "Something.symbols.json", data: emptySymbolGraphData)
+        ])
+        let fs = try TestFileSystem(folders: [folders])
+        
+        let bundles = try fs.bundles()
+        XCTAssertEqual(bundles.count, 1)
+        
+        let bundle = try XCTUnwrap(bundles.first)
+        XCTAssertFalse(bundle.markupURLs.isEmpty)
+        XCTAssertFalse(bundle.miscResourceURLs.isEmpty)
+        XCTAssertFalse(bundle.symbolGraphURLs.isEmpty)
+        
+        XCTAssert(bundle.markupURLs.allSatisfy(\.isFileURL))
+        XCTAssert(bundle.miscResourceURLs.allSatisfy(\.isFileURL))
+        XCTAssert(bundle.symbolGraphURLs.allSatisfy(\.isFileURL))
+    }
 }