Skip to content

Commit 5891df5

Browse files
plemarquandplemarquand
committed
Use fixed version build tools link
The current link to the VS build tools points to an evergreen bootstrapper. This means that when a new v17 buildtools.exe is available the link is updated with the new version. Since we're verifying that the downloaded buildtools.exe file hash matches a known value the windows Docker setup breaks each time a new buildtools is released. Instead, use a fixed version permalink that will not change. The specific version used is version `17.11.6`, build `17.11.35431.28`. See: https://learn.microsoft.com/en-gb/visualstudio/releases/2022/release-history#fixed-version-bootstrappers
1 parent 0246d26 commit 5891df5

File tree

10 files changed

+20
-20
lines changed

10 files changed

+20
-20
lines changed

Diff for: ‎5.10/windows/1809/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
8989
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9090

9191
# Install Visual Studio Build Tools
92-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
93-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
92+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
93+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
9494
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
9595
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
9696
Write-Host '✓'; \

Diff for: ‎5.10/windows/LTSC2022/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
8989
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9090

9191
# Install Visual Studio Build Tools
92-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
93-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
92+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
93+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
9494
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
9595
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
9696
Write-Host '✓'; \

Diff for: ‎5.9/windows/LTSC2022/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
8989
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9090

9191
# Install Visual Studio Build Tools
92-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
93-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
92+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
93+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
9494
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
9595
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
9696
Write-Host '✓'; \

Diff for: ‎6.0/windows/1809/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
8989
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9090

9191
# Install Visual Studio Build Tools
92-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
93-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
92+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
93+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
9494
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
9595
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
9696
Write-Host '✓'; \

Diff for: ‎6.0/windows/LTSC2022/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
8989
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9090

9191
# Install Visual Studio Build Tools
92-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
93-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
92+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
93+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
9494
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
9595
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
9696
Write-Host '✓'; \

Diff for: ‎nightly-6.0/windows/1809/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
9595
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9696

9797
# Install Visual Studio Build Tools
98-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
99-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
98+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
99+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
100100
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
101101
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
102102
Write-Host '✓'; \

Diff for: ‎nightly-6.0/windows/LTSC2022/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
9595
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9696

9797
# Install Visual Studio Build Tools
98-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
99-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
98+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
99+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
100100
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
101101
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
102102
Write-Host '✓'; \

Diff for: ‎nightly-main/windows/1809/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
9595
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9696

9797
# Install Visual Studio Build Tools
98-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
99-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
98+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
99+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
100100
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
101101
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
102102
Write-Host '✓'; \

Diff for: ‎nightly-main/windows/LTSC2022/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
9595
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
9696

9797
# Install Visual Studio Build Tools
98-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
99-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
98+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
99+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
100100
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
101101
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
102102
Write-Host '✓'; \

Diff for: ‎swift-ci/main/windows/LTSC2022/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,8 @@ RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:PY39});
128128
Remove-Item -ErrorAction SilentlyContinue -Force -Recurse ${env:TEMP}\*
129129

130130
# Install Visual Studio Build Tools
131-
ARG VSB=https://aka.ms/vs/17/release/vs_buildtools.exe
132-
ARG VSB_SHA256=D4E08524CB0E5BD061A24F507928D1CFB91DCE192C5E12ED964B8343FC4CDEDD
131+
ARG VSB=https://download.visualstudio.microsoft.com/download/pr/1affe83d-fcd4-41b0-bb9b-d62f64a857c4/b5155f40a7694f3613311814b00803848a3e9567fddd98aa70797d21ac29420f/vs_BuildTools.exe
132+
ARG VSB_SHA256=B5155F40A7694F3613311814B00803848A3E9567FDDD98AA70797D21AC29420F
133133
RUN Write-Host -NoNewLine ('Downloading {0} ... ' -f ${env:VSB}); \
134134
Invoke-WebRequest -Uri ${env:VSB} -OutFile vs_buildtools.exe; \
135135
Write-Host '✓'; \

0 commit comments

Comments
 (0)