Skip to content

Commit 359331a

Browse files
committed
Address PR comments
* Remove taskStarted outputStream emissions * Propagate exception if unable to find path
1 parent f14600c commit 359331a

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

Sources/SwiftBuildSupport/SwiftBuildSystem.swift

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -377,13 +377,6 @@ public final class SwiftBuildSystemMessageHandler {
377377
self.observabilityScope.emit(info: "\(info.executionDescription)")
378378
}
379379

380-
if self.logLevel.isVerbose {
381-
if let commandLineDisplay = info.commandLineDisplayString {
382-
self.outputStream.send("\(info.executionDescription)\n\(commandLineDisplay)")
383-
} else {
384-
self.outputStream.send("\(info.executionDescription)")
385-
}
386-
}
387380
let targetInfo = try buildState.target(for: info)
388381
buildSystem.delegate?.buildSystem(buildSystem, willStartCommand: BuildSystemCommand(info, targetInfo: targetInfo))
389382
buildSystem.delegate?.buildSystem(buildSystem, didStartCommand: BuildSystemCommand(info, targetInfo: targetInfo))
@@ -399,8 +392,8 @@ public final class SwiftBuildSystemMessageHandler {
399392
let targetInfo = try buildState.target(for: startedInfo)
400393
buildSystem.delegate?.buildSystem(buildSystem, didFinishCommand: BuildSystemCommand(startedInfo, targetInfo: targetInfo))
401394
if let targetName = targetInfo?.targetName {
402-
serializedDiagnosticPathsByTargetName[targetName, default: []].append(contentsOf: startedInfo.serializedDiagnosticsPaths.compactMap {
403-
try? Basics.AbsolutePath(validating: $0.pathString)
395+
try serializedDiagnosticPathsByTargetName[targetName, default: []].append(contentsOf: startedInfo.serializedDiagnosticsPaths.compactMap {
396+
try Basics.AbsolutePath(validating: $0.pathString)
404397
})
405398
}
406399
if buildSystem.enableTaskBacktraces {

0 commit comments

Comments
 (0)