Rollback createWorkingCopy async change

Author: plemarquand

Sources/SourceControl/GitRepository.swift

@@ -229,7 +229,7 @@ public struct GitRepositoryProvider: RepositoryProvider, Cancellable {
         sourcePath: Basics.AbsolutePath,
         at destinationPath: Basics.AbsolutePath,
         editable: Bool
-    ) async throws -> WorkingCheckout {
+    ) throws -> WorkingCheckout {
         if editable {
             // For editable clones, i.e. the user is expected to directly work on them, first we create
             // a clone from our cache of repositories and then we replace the remote to the one originally

Sources/SourceControl/Repository.swift

@@ -121,7 +121,7 @@ public protocol RepositoryProvider: Cancellable {
         repository: RepositorySpecifier,
         sourcePath: AbsolutePath,
         at destinationPath: AbsolutePath,
-        editable: Bool) async throws -> WorkingCheckout
+        editable: Bool) throws -> WorkingCheckout
 
     /// Returns true if a working repository exists at `path`
     func workingCopyExists(at path: AbsolutePath) throws -> Bool

Sources/SourceControl/RepositoryManager.swift

@@ -433,8 +433,8 @@ public class RepositoryManager: Cancellable {
         _ handle: RepositoryHandle,
         at destinationPath: Basics.AbsolutePath,
         editable: Bool
-    ) async throws -> WorkingCheckout {
-        try await self.provider.createWorkingCopy(
+    ) throws -> WorkingCheckout {
+        try self.provider.createWorkingCopy(
             repository: handle.repository,
             sourcePath: self.path.appending(handle.subpath),
             at: destinationPath,
@@ -549,7 +549,7 @@ extension RepositoryManager {
         ///
         ///   - editable: The clone is expected to be edited by user.
         public func createWorkingCopy(at path: Basics.AbsolutePath, editable: Bool) async throws -> WorkingCheckout {
-            return try await self.manager.createWorkingCopy(self, at: path, editable: editable)
+            return try self.manager.createWorkingCopy(self, at: path, editable: editable)
         }
     }
 }

Sources/_InternalTestSupport/InMemoryGitRepository.swift

@@ -458,7 +458,7 @@ public final class InMemoryGitRepositoryProvider: RepositoryProvider {
         sourcePath: AbsolutePath,
         at destinationPath: AbsolutePath,
         editable: Bool
-    ) async throws -> WorkingCheckout {
+    ) throws -> WorkingCheckout {
         guard let checkout = fetchedMap[sourcePath] else {
             throw InternalError("unknown checkout at \(sourcePath)")
         }

Tests/SourceControlTests/RepositoryManagerTests.swift

@@ -533,7 +533,7 @@ final class RepositoryManagerTests: XCTestCase {
                 fatalError("should not be called")
             }
 
-            func createWorkingCopy(repository: RepositorySpecifier, sourcePath: AbsolutePath, at destinationPath: AbsolutePath, editable: Bool) async throws -> WorkingCheckout {
+            func createWorkingCopy(repository: RepositorySpecifier, sourcePath: AbsolutePath, at destinationPath: AbsolutePath, editable: Bool) throws -> WorkingCheckout {
                 fatalError("should not be called")
             }
 
@@ -607,7 +607,7 @@ final class RepositoryManagerTests: XCTestCase {
                 return MockRepository()
             }
 
-            func createWorkingCopy(repository: RepositorySpecifier, sourcePath: AbsolutePath, at destinationPath: AbsolutePath, editable: Bool) async throws -> WorkingCheckout {
+            func createWorkingCopy(repository: RepositorySpecifier, sourcePath: AbsolutePath, at destinationPath: AbsolutePath, editable: Bool) throws -> WorkingCheckout {
                 fatalError("should not be called")
             }
 
@@ -763,10 +763,10 @@ private class DummyRepositoryProvider: RepositoryProvider {
         return DummyRepository(provider: self)
     }
 
-    func createWorkingCopy(repository: RepositorySpecifier, sourcePath: AbsolutePath, at destinationPath: AbsolutePath, editable: Bool) async throws -> WorkingCheckout  {
+    func createWorkingCopy(repository: RepositorySpecifier, sourcePath: AbsolutePath, at destinationPath: AbsolutePath, editable: Bool) throws -> WorkingCheckout  {
         try self.fileSystem.createDirectory(destinationPath)
         try self.fileSystem.writeFileContents(destinationPath.appending("README.txt"), bytes: "Hi")
-        return try await self.openWorkingCopy(at: destinationPath)
+        return DummyWorkingCheckout(at: destinationPath)
     }
 
     func workingCopyExists(at path: AbsolutePath) throws -> Bool {