Skip to content

Commit 893e879

Browse files
committed
Fix the symbolGraphExtractorBuildSettings test
1 parent 192bf56 commit 893e879

1 file changed

Lines changed: 12 additions & 20 deletions

File tree

Tests/SwiftBuildSupportTests/PIFBuilderTests.swift

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1092,27 +1092,19 @@ struct PIFBuilderTests {
10921092
try await withGeneratedPIF(fromFixture: "CFamilyTargets/ModuleMapGenerationCases") { pif, observabilitySystem in
10931093
#expect(observabilitySystem.diagnostics.filter { $0.severity == .error }.isEmpty)
10941094

1095-
// C target: all three symbol graph settings should be present
1096-
let cConfig = try pif.workspace
1097-
.project(named: "ModuleMapGenerationCases")
1098-
.target(named: "UmbrellaHeader")
1099-
.buildConfig(named: .release)
1100-
1101-
let expectedCDir = "$(TARGET_BUILD_DIR)/$(CURRENT_ARCH)/UmbrellaHeader.symbolgraphs"
1102-
#expect(cConfig.settings[.SYMBOL_GRAPH_EXTRACTOR_OUTPUT_DIR] == expectedCDir)
1103-
#expect(cConfig.settings[.TAPI_EXTRACT_API_OUTPUT_DIR] == expectedCDir)
1104-
#expect(cConfig.settings[.DOCC_EXTRACT_PROJECT_HEADERS_DOCUMENTATION] == "YES")
1105-
1106-
// Swift executable target: settings should also be present
1107-
let swiftConfig = try pif.workspace
1108-
.project(named: "ModuleMapGenerationCases")
1109-
.target(named: "Baz")
1110-
.buildConfig(named: .release)
1095+
// configureSourceModuleBuildSettings is called for every source module via the same
1096+
// delegate path, so verifying on representative C targets is sufficient coverage.
1097+
for targetName in ["UmbrellaHeader", "FlatInclude"] {
1098+
let config = try pif.workspace
1099+
.project(named: "ModuleMapGenerationCases")
1100+
.target(named: targetName)
1101+
.buildConfig(named: .release)
11111102

1112-
let expectedSwiftDir = "$(TARGET_BUILD_DIR)/$(CURRENT_ARCH)/Baz.symbolgraphs"
1113-
#expect(swiftConfig.settings[.SYMBOL_GRAPH_EXTRACTOR_OUTPUT_DIR] == expectedSwiftDir)
1114-
#expect(swiftConfig.settings[.TAPI_EXTRACT_API_OUTPUT_DIR] == expectedSwiftDir)
1115-
#expect(swiftConfig.settings[.DOCC_EXTRACT_PROJECT_HEADERS_DOCUMENTATION] == "YES")
1103+
let expectedDir = "$(TARGET_BUILD_DIR)/$(CURRENT_ARCH)/\(targetName).symbolgraphs"
1104+
#expect(config.settings[.SYMBOL_GRAPH_EXTRACTOR_OUTPUT_DIR] == expectedDir, "target: \(targetName)")
1105+
#expect(config.settings[.TAPI_EXTRACT_API_OUTPUT_DIR] == expectedDir, "target: \(targetName)")
1106+
#expect(config.settings[.DOCC_EXTRACT_PROJECT_HEADERS_DOCUMENTATION] == "YES", "target: \(targetName)")
1107+
}
11161108
}
11171109
}
11181110

0 commit comments

Comments
 (0)