-
Notifications
You must be signed in to change notification settings - Fork 433
/
Copy pathExpandEditorPlaceholder.swift
477 lines (431 loc) · 14.8 KB
/
ExpandEditorPlaceholder.swift
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2023 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
#if swift(>=6)
import SwiftBasicFormat
import SwiftParser
public import SwiftSyntax
import SwiftSyntaxBuilder
#else
import SwiftBasicFormat
import SwiftParser
import SwiftSyntax
import SwiftSyntaxBuilder
#endif
/// Expands an editor placeholder, taking into accounts its provided type
/// information (if any).
///
/// Placeholders must start with '<#' and end with
/// '#>'. They can be one of the following formats:
/// ```
/// 'T##' display-string '##' type-string ('##' type-for-expansion-string)?
/// 'T##' display-and-type-string
/// display-string
/// ```
/// It is required that '##' is not a valid substring of display-string or
/// type-string. If this ends up not the case for some reason, we can consider
/// adding escaping for '##'.
///
/// The type string provided in the placeholder (preferring
/// `type-for-expansion-string`), is parsed into a syntax node. If that node is
/// a `FunctionTypeSyntax` then the placeholder is expanded into a
/// `ClosureExprSyntax`. Otherwise it is expanded as is, which is also the case
/// for when only a display string is provided.
///
/// ## Function Typed Placeholder
/// ### Before
/// ```swift
/// <#T##(Int) -> String##(Int) -> String##(_ someInt: Int) -> String#>
/// ```
///
/// ### After
/// ```swift
/// { someInt in
/// <#T##String#>
/// }
/// ```
///
/// ## Other Type Placeholder
/// ### Before
/// ```swift
/// <#T##Int#>
/// ```
///
/// ### After
/// ```swift
/// Int
/// ```
///
/// ## No Type Placeholder
/// ### Before
/// ```swift
/// <#anything here#>
/// ```
///
/// ## After
/// ```swift
/// anything here
/// ```
struct ExpandSingleEditorPlaceholder: EditRefactoringProvider {
struct Context {
let indentationWidth: Trivia?
let initialIndentation: Trivia
init(indentationWidth: Trivia? = nil, initialIndentation: Trivia = []) {
self.indentationWidth = indentationWidth
self.initialIndentation = initialIndentation
}
}
static func textRefactor(syntax token: TokenSyntax, in context: Context = Context()) -> [SourceEdit] {
guard let placeholder = EditorPlaceholderData(token: token) else {
return []
}
let expanded: String
switch placeholder {
case .basic(let text):
expanded = String(text)
case .typed(let text, let type):
if let functionType = type.as(FunctionTypeSyntax.self) {
let basicFormat = BasicFormat(
indentationWidth: context.indentationWidth,
initialIndentation: context.initialIndentation
)
var formattedExpansion = functionType.closureExpansion.formatted(using: basicFormat).description
// Strip the initial indentation from the placeholder itself. We only introduced the initial indentation to
// format consecutive lines. We don't want it at the front of the initial line because it replaces an expression
// that might be in the middle of a line.
if formattedExpansion.hasPrefix(context.initialIndentation.description) {
formattedExpansion = String(formattedExpansion.dropFirst(context.initialIndentation.description.count))
}
expanded = formattedExpansion
} else {
expanded = String(text)
}
}
return [
SourceEdit.replace(token, with: token.leadingTrivia.description + expanded + token.trailingTrivia.description)
]
}
}
/// If a function-typed placeholder is the argument to a non-trailing closure
/// call, expands it and any adjacent function-typed placeholders to trailing
/// closures on that call. All other placeholders will expand as per
/// `ExpandEditorPlaceholder`.
///
/// ## Before
/// ```swift
/// foo(
/// closure1: <#T##(Int) -> String##(Int) -> String##(_ someInt: Int) -> String#>,
/// normalArg: <#T##Int#>,
/// closure2: { ... },
/// closure3: <#T##(Int) -> String##(Int) -> String##(_ someInt: Int) -> String#>,
/// closure4: <#T##(Int) -> String##(Int) -> String##(_ someInt: Int) -> String#>
/// )
/// ```
///
/// ## `closure3` or `closure4` Expansion
/// ```swift
/// foo(
/// closure1: <#T##(Int) -> String##(Int) -> String##(_ someInt: Int) -> String#>,
/// normalArg: <#T##Int#>,
/// closure2: { ... }
/// ) { someInt in
/// <#T##String#>
/// } closure2: { someInt in
/// <#T##String#>
/// }
/// ```
///
/// Expansion on `closure1` and `normalArg` is the same as `ExpandSingleEditorPlaceholder`.
public struct ExpandEditorPlaceholder: EditRefactoringProvider {
public struct Context {
public let indentationWidth: Trivia?
public init(indentationWidth: Trivia? = nil) {
self.indentationWidth = indentationWidth
}
}
public static func textRefactor(syntax token: TokenSyntax, in context: Context = Context()) -> [SourceEdit] {
guard let placeholder = token.parent?.as(DeclReferenceExprSyntax.self),
placeholder.baseName.isEditorPlaceholder,
let arg = placeholder.parent?.as(LabeledExprSyntax.self),
let argList = arg.parent?.as(LabeledExprListSyntax.self),
let call = argList.parent?.as(FunctionCallExprSyntax.self),
let expandedTrailingClosures = ExpandEditorPlaceholdersToTrailingClosures.expandTrailingClosurePlaceholders(
in: call,
ifIncluded: arg,
indentationWidth: context.indentationWidth
)
else {
return ExpandSingleEditorPlaceholder.textRefactor(syntax: token)
}
return [SourceEdit.replace(call, with: expandedTrailingClosures.description)]
}
}
/// Expand all the editor placeholders in the function call that can be converted to trailing closures.
///
/// ## Before
/// ```swift
/// foo(
/// arg: <#T##Int#>,
/// firstClosure: <#T##(Int) -> String##(Int) -> String##(_ someInt: Int) -> String#>,
/// secondClosure: <#T##(Int) -> String##(Int) -> String##(_ someInt: Int) -> String#>
/// )
/// ```
///
/// ## Expansion of `foo`
/// ```swift
/// foo(
/// arg: <#T##Int#>,
/// ) { someInt in
/// <#T##String#>
/// } secondClosure: { someInt in
/// <#T##String#>
/// }
/// ```
public struct ExpandEditorPlaceholdersToTrailingClosures: SyntaxRefactoringProvider {
public struct Context {
public let indentationWidth: Trivia?
public init(indentationWidth: Trivia? = nil) {
self.indentationWidth = indentationWidth
}
}
public static func refactor(
syntax call: FunctionCallExprSyntax,
in context: Context = Context()
) -> FunctionCallExprSyntax? {
return Self.expandTrailingClosurePlaceholders(in: call, ifIncluded: nil, indentationWidth: context.indentationWidth)
}
/// If the given argument is `nil` or one of the last arguments that are all
/// function-typed placeholders and this call doesn't have a trailing
/// closure, then return a replacement of this call with one that uses
/// closures based on the function types provided by each editor placeholder.
/// Otherwise return nil.
fileprivate static func expandTrailingClosurePlaceholders(
in call: FunctionCallExprSyntax,
ifIncluded arg: LabeledExprSyntax?,
indentationWidth: Trivia?
) -> FunctionCallExprSyntax? {
guard let expanded = call.expandTrailingClosurePlaceholders(ifIncluded: arg, indentationWidth: indentationWidth)
else {
return nil
}
let callToTrailingContext = CallToTrailingClosures.Context(
startAtArgument: call.arguments.count - expanded.numClosures
)
guard let trailing = CallToTrailingClosures.refactor(syntax: expanded.expr, in: callToTrailingContext) else {
return nil
}
return trailing
}
}
extension FunctionTypeSyntax {
/// Return a closure expression for this function type, eg.
/// ```
/// (_ someInt: Int) -> String
/// ```
/// would become
/// ```
/// { someInt in
/// <#T##String#>
/// }
/// ```
fileprivate var closureExpansion: ClosureExprSyntax {
let closureSignature: ClosureSignatureSyntax?
if !parameters.isEmpty {
let args = ClosureShorthandParameterListSyntax {
for arg in parameters {
ClosureShorthandParameterSyntax(name: arg.expansionNameToken())
}
}
closureSignature = ClosureSignatureSyntax(parameterClause: .simpleInput(args))
} else {
closureSignature = nil
}
// Single statement for the body - the placeholder-ed type if non-void and
// 'code' otherwise.
let ret = returnClause.type.description
let placeholder: String
if ret == "Void" || ret == "()" {
placeholder = wrapInTypePlaceholder("code", type: "Void")
} else {
placeholder = wrapInTypePlaceholder(ret, type: ret)
}
let statementPlaceholder = DeclReferenceExprSyntax(
baseName: .identifier(placeholder)
)
let closureStatement = CodeBlockItemSyntax(
item: .expr(ExprSyntax(statementPlaceholder))
)
return ClosureExprSyntax(
leftBrace: .leftBraceToken(),
signature: closureSignature,
statements: CodeBlockItemListSyntax([closureStatement]),
rightBrace: .rightBraceToken()
)
}
}
extension TupleTypeElementSyntax {
/// Return a token to use as the parameter name in the expanded closure.
/// We prefer the argument name if there is one and it isn't a wildcard,
/// falling back to the label with the same conditions, and finally just the
/// placeholder-ed type otherwise.
fileprivate func expansionNameToken() -> TokenSyntax {
if let secondName = secondName, secondName.tokenKind != .wildcard {
return secondName
}
if let firstName, firstName.tokenKind != .wildcard {
return firstName
}
return .identifier(wrapInPlaceholder(type.description))
}
}
extension FunctionCallExprSyntax {
/// If the given argument is `nil` or one of the last arguments that are all
/// function-typed placeholders and this call doesn't have a trailing
/// closure, then return a replacement of this call with one that uses
/// closures based on the function types provided by each editor placeholder.
/// Otherwise return nil.
fileprivate func expandTrailingClosurePlaceholders(
ifIncluded: LabeledExprSyntax?,
indentationWidth: Trivia?
) -> (expr: FunctionCallExprSyntax, numClosures: Int)? {
var includedArg = false
var argsToExpand = 0
for arg in arguments.reversed() {
guard let expr = arg.expression.as(DeclReferenceExprSyntax.self),
expr.baseName.isEditorPlaceholder,
let data = EditorPlaceholderData(token: expr.baseName),
case .typed(_, let type) = data,
type.is(FunctionTypeSyntax.self)
else {
break
}
if arg == ifIncluded {
includedArg = true
}
argsToExpand += 1
}
guard includedArg || ifIncluded == nil else {
return nil
}
let lineIndentation = self.firstToken(viewMode: .sourceAccurate)?.indentationOfLine ?? []
var expandedArgs = [LabeledExprSyntax]()
for arg in arguments.suffix(argsToExpand) {
let edits = ExpandSingleEditorPlaceholder.textRefactor(
syntax: arg.expression.cast(DeclReferenceExprSyntax.self).baseName,
in: ExpandSingleEditorPlaceholder.Context(
indentationWidth: indentationWidth,
initialIndentation: lineIndentation
)
)
guard edits.count == 1, let edit = edits.first, !edit.replacement.isEmpty else {
return nil
}
var parser = Parser(edit.replacement)
let expr = ExprSyntax.parse(from: &parser)
expandedArgs.append(
arg.detached.with(\.expression, expr)
)
}
let originalArgs = arguments.dropLast(argsToExpand)
return (
detached.with(\.arguments, LabeledExprListSyntax(originalArgs + expandedArgs)),
expandedArgs.count
)
}
}
/// Placeholder text must start with '<#' and end with
/// '#>'. Placeholders can be one of the following formats:
/// ```
/// 'T##' display-string '##' type-string ('##' type-for-expansion-string)?
/// 'T##' display-and-type-string
/// display-string
/// ```
///
/// NOTE: It is required that '##' is not a valid substring of display-string
/// or type-string. If this ends up not the case for some reason, we can consider
/// adding escaping for '##'.
@_spi(SourceKitLSP)
public enum EditorPlaceholderData {
case basic(text: Substring)
case typed(text: Substring, type: TypeSyntax)
init?(token: TokenSyntax) {
self.init(text: token.text)
}
@_spi(SourceKitLSP)
public init?(text: String) {
guard isPlaceholder(text) else {
return nil
}
var text = text.dropFirst(2).dropLast(2)
if !text.hasPrefix("T##") {
// No type information
self = .basic(text: text)
return
}
// Drop 'T##'
text = text.dropFirst(3)
var typeText: Substring
(text, typeText) = split(text, separatedBy: "##")
if typeText.isEmpty {
// Only type information present
self.init(typeText: text)
return
}
// Have type text, see if we also have expansion text
let expansionText: Substring
(typeText, expansionText) = split(typeText, separatedBy: "##")
if expansionText.isEmpty {
if typeText.isEmpty {
// No type information
self = .basic(text: text)
} else {
// Only have type text, use it for the placeholder expansion
self.init(typeText: typeText)
}
return
}
// Have expansion type text, use it for the placeholder expansion
self.init(typeText: expansionText)
}
init(typeText: Substring) {
var parser = Parser(String(typeText))
let type: TypeSyntax = TypeSyntax.parse(from: &parser)
if type.hasError {
self = .basic(text: typeText)
} else {
self = .typed(text: typeText, type: type)
}
}
}
@_spi(Testing)
public func isPlaceholder(_ str: String) -> Bool {
return str.hasPrefix(placeholderStart) && str.hasSuffix(placeholderEnd)
}
@_spi(Testing)
public func wrapInPlaceholder(_ str: String) -> String {
return placeholderStart + str + placeholderEnd
}
@_spi(Testing)
public func wrapInTypePlaceholder(_ str: String, type: String) -> String {
return wrapInPlaceholder("T##" + str + "##" + type)
}
/// Split the given string into two components on the first instance of
/// `separatedBy`. The second element is empty if `separatedBy` is missing
/// from the initial string.
fileprivate func split(_ text: Substring, separatedBy separator: String) -> (Substring, Substring) {
var rest = text
while !rest.isEmpty && !rest.hasPrefix(separator) {
rest = rest.dropFirst()
}
return (text.dropLast(rest.count), rest.dropFirst(2))
}
fileprivate let placeholderStart: String = "<#"
fileprivate let placeholderEnd: String = "#>"