Stop using switch expressions

Author: DougGregor

Diff for: Sources/SwiftRefactor/PackageManifest/AddTarget.swift

@@ -106,12 +106,12 @@ public struct AddTarget: ManifestEditRefactoringProvider {
       newElement: target.asSyntax()
     )
 
-    let outerDirectory: String? =
-      switch target.type {
-      case .binary, .plugin, .system: nil
-      case .executable, .library, .macro: "Sources"
-      case .test: "Tests"
-      }
+    let outerDirectory: String?
+    switch target.type {
+    case .binary, .plugin, .system: outerDirectory = nil
+    case .executable, .library, .macro: outerDirectory = "Sources"
+    case .test: outerDirectory = "Tests"
+    }
 
     guard let outerDirectory else {
       return PackageEditResult(
@@ -224,13 +224,13 @@ public struct AddTarget: ManifestEditRefactoringProvider {
       }
     }
 
-    let sourceFileText: SourceFileSyntax =
-      switch target.type {
-      case .binary, .plugin, .system:
-        fatalError("should have exited above")
+    let sourceFileText: SourceFileSyntax
+    switch target.type {
+    case .binary, .plugin, .system:
+      fatalError("should have exited above")
 
-      case .macro:
-        """
+    case .macro:
+      sourceFileText = """
         \(imports)
         struct \(raw: target.sanitizedName): Macro {
             /// TODO: Implement one or more of the protocols that inherit
@@ -242,16 +242,16 @@ public struct AddTarget: ManifestEditRefactoringProvider {
         }
         """
 
-      case .test:
-        switch configuration.testHarness {
-        case .none:
-          """
+    case .test:
+      switch configuration.testHarness {
+      case .none:
+        sourceFileText = """
           \(imports)
           // Test code here
           """
 
-        case .xctest:
-          """
+      case .xctest:
+        sourceFileText = """
           \(imports)
           class \(raw: target.sanitizedName)Tests: XCTestCase {
               func test\(raw: target.sanitizedName)() {
@@ -260,8 +260,8 @@ public struct AddTarget: ManifestEditRefactoringProvider {
           }
           """
 
-        case .swiftTesting:
-          """
+      case .swiftTesting:
+        sourceFileText = """
           \(imports)
           @Suite
           struct \(raw: target.sanitizedName)Tests {
@@ -271,15 +271,15 @@ public struct AddTarget: ManifestEditRefactoringProvider {
               }
           }
           """
-        }
+      }
 
-      case .library:
-        """
+    case .library:
+      sourceFileText = """
         \(imports)
         """
 
-      case .executable:
-        """
+    case .executable:
+      sourceFileText = """
         \(imports)
         @main
         struct \(raw: target.sanitizedName)Main {
@@ -288,7 +288,7 @@ public struct AddTarget: ManifestEditRefactoringProvider {
             }
         }
         """
-      }
+    }
 
     auxiliaryFiles.addSourceFile(
       path: sourceFilePath,