Enable unacceptable language check

Fixes #2990

Author: ahoppen

.github/workflows/pull_request.yml

@@ -20,7 +20,5 @@ jobs:
       docs_check_enabled: false
       # https://github.com/swiftlang/swift-syntax/issues/2988
       format_check_enabled: false
-      # https://github.com/swiftlang/swift-syntax/issues/2990
-      unacceptable_language_check_enabled: false
       # https://github.com/swiftlang/swift-syntax/issues/2991
       yamllint_check_enabled: false

CodeGeneration/Sources/generate-swift-syntax/templates/swiftsyntax/SyntaxBaseNodesFile.swift

@@ -42,7 +42,7 @@ let syntaxBaseNodesFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
       /// These methods enable casting between syntax node types within the same
       /// base node protocol hierarchy (e.g., ``DeclSyntaxProtocol``).
       ///
-      /// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``, 
+      /// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``,
       /// ``SyntaxProtocol.is(_:)``, and ``SyntaxProtocol.cast(_:)``), these often aren't
       /// appropriate for use on types conforming to a specific base node protocol
       /// like ``\#(node.kind.protocolType)``. That's because at this level,
@@ -51,7 +51,7 @@ let syntaxBaseNodesFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
       ///
       /// To guide developers toward correct usage, this extension provides overloads
       /// of these casting methods that are restricted to the same base node type.
-      /// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as 
+      /// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as
       /// deprecated, indicating that they will always fail when used in this context.
       extension \#(node.kind.protocolType) {
         /// Checks if the current syntax node can be cast to a given specialized syntax type.
@@ -184,9 +184,8 @@ let syntaxBaseNodesFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
         """
         /// Create a \(raw: node.kind.doccLink) node from a specialized syntax node.
         public init(_ syntax: __shared some \(node.kind.protocolType)) {
-          // We know this cast is going to succeed. Go through init(_: SyntaxData)
-          // to do a sanity check and verify the kind matches in debug builds and get
-          // maximum performance in release builds.
+          // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+          // verify the kind matches in debug builds and get maximum performance in release builds.
           self = Syntax(syntax).cast(Self.self)
         }
         """
@@ -205,9 +204,8 @@ let syntaxBaseNodesFile = SourceFileSyntax(leadingTrivia: copyrightHeader) {
       DeclSyntax(
         """
         public init(fromProtocol syntax: __shared \(node.kind.protocolType)) {
-          // We know this cast is going to succeed. Go through init(_: SyntaxData)
-          // to do a sanity check and verify the kind matches in debug builds and get
-          // maximum performance in release builds.
+          // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+          // verify the kind matches in debug builds and get maximum performance in release builds.
           self = Syntax(syntax).cast(Self.self)
         }
         """

Sources/SwiftParser/Expressions.swift

@@ -583,7 +583,7 @@ extension Parser {
   ) -> RawExprSyntax {
     // Try parse a single value statement as an expression (e.g do/if/switch).
     // Note we do this here in parseUnaryExpression as we don't allow postfix
-    // syntax to hang off such expressions to avoid ambiguities such as postfix
+    // syntax to be attached to such expressions to avoid ambiguities such as postfix
     // '.member', which can currently be parsed as a static dot member for a
     // result builder.
     switch self.at(anyIn: SingleValueStatementExpression.self) {

Sources/SwiftSyntax/generated/SyntaxBaseNodes.swift

@@ -26,7 +26,7 @@ public protocol DeclSyntaxProtocol: SyntaxProtocol {}
 /// These methods enable casting between syntax node types within the same
 /// base node protocol hierarchy (e.g., ``DeclSyntaxProtocol``).
 ///
-/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``, 
+/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``,
 /// ``SyntaxProtocol.is(_:)``, and ``SyntaxProtocol.cast(_:)``), these often aren't
 /// appropriate for use on types conforming to a specific base node protocol
 /// like ``DeclSyntaxProtocol``. That's because at this level,
@@ -35,7 +35,7 @@ public protocol DeclSyntaxProtocol: SyntaxProtocol {}
 ///
 /// To guide developers toward correct usage, this extension provides overloads
 /// of these casting methods that are restricted to the same base node type.
-/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as 
+/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as
 /// deprecated, indicating that they will always fail when used in this context.
 extension DeclSyntaxProtocol {
   /// Checks if the current syntax node can be cast to a given specialized syntax type.
@@ -184,9 +184,8 @@ public struct DeclSyntax: DeclSyntaxProtocol, SyntaxHashable {
 
   /// Create a ``DeclSyntax`` node from a specialized syntax node.
   public init(_ syntax: __shared some DeclSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 
@@ -199,9 +198,8 @@ public struct DeclSyntax: DeclSyntaxProtocol, SyntaxHashable {
   }
 
   public init(fromProtocol syntax: __shared DeclSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 
@@ -327,7 +325,7 @@ public protocol ExprSyntaxProtocol: SyntaxProtocol {}
 /// These methods enable casting between syntax node types within the same
 /// base node protocol hierarchy (e.g., ``DeclSyntaxProtocol``).
 ///
-/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``, 
+/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``,
 /// ``SyntaxProtocol.is(_:)``, and ``SyntaxProtocol.cast(_:)``), these often aren't
 /// appropriate for use on types conforming to a specific base node protocol
 /// like ``ExprSyntaxProtocol``. That's because at this level,
@@ -336,7 +334,7 @@ public protocol ExprSyntaxProtocol: SyntaxProtocol {}
 ///
 /// To guide developers toward correct usage, this extension provides overloads
 /// of these casting methods that are restricted to the same base node type.
-/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as 
+/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as
 /// deprecated, indicating that they will always fail when used in this context.
 extension ExprSyntaxProtocol {
   /// Checks if the current syntax node can be cast to a given specialized syntax type.
@@ -512,9 +510,8 @@ public struct ExprSyntax: ExprSyntaxProtocol, SyntaxHashable {
 
   /// Create a ``ExprSyntax`` node from a specialized syntax node.
   public init(_ syntax: __shared some ExprSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 
@@ -527,9 +524,8 @@ public struct ExprSyntax: ExprSyntaxProtocol, SyntaxHashable {
   }
 
   public init(fromProtocol syntax: __shared ExprSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 
@@ -685,7 +681,7 @@ public protocol PatternSyntaxProtocol: SyntaxProtocol {}
 /// These methods enable casting between syntax node types within the same
 /// base node protocol hierarchy (e.g., ``DeclSyntaxProtocol``).
 ///
-/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``, 
+/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``,
 /// ``SyntaxProtocol.is(_:)``, and ``SyntaxProtocol.cast(_:)``), these often aren't
 /// appropriate for use on types conforming to a specific base node protocol
 /// like ``PatternSyntaxProtocol``. That's because at this level,
@@ -694,7 +690,7 @@ public protocol PatternSyntaxProtocol: SyntaxProtocol {}
 ///
 /// To guide developers toward correct usage, this extension provides overloads
 /// of these casting methods that are restricted to the same base node type.
-/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as 
+/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as
 /// deprecated, indicating that they will always fail when used in this context.
 extension PatternSyntaxProtocol {
   /// Checks if the current syntax node can be cast to a given specialized syntax type.
@@ -826,9 +822,8 @@ public struct PatternSyntax: PatternSyntaxProtocol, SyntaxHashable {
 
   /// Create a ``PatternSyntax`` node from a specialized syntax node.
   public init(_ syntax: __shared some PatternSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 
@@ -841,9 +836,8 @@ public struct PatternSyntax: PatternSyntaxProtocol, SyntaxHashable {
   }
 
   public init(fromProtocol syntax: __shared PatternSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 
@@ -952,7 +946,7 @@ public protocol StmtSyntaxProtocol: SyntaxProtocol {}
 /// These methods enable casting between syntax node types within the same
 /// base node protocol hierarchy (e.g., ``DeclSyntaxProtocol``).
 ///
-/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``, 
+/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``,
 /// ``SyntaxProtocol.is(_:)``, and ``SyntaxProtocol.cast(_:)``), these often aren't
 /// appropriate for use on types conforming to a specific base node protocol
 /// like ``StmtSyntaxProtocol``. That's because at this level,
@@ -961,7 +955,7 @@ public protocol StmtSyntaxProtocol: SyntaxProtocol {}
 ///
 /// To guide developers toward correct usage, this extension provides overloads
 /// of these casting methods that are restricted to the same base node type.
-/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as 
+/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as
 /// deprecated, indicating that they will always fail when used in this context.
 extension StmtSyntaxProtocol {
   /// Checks if the current syntax node can be cast to a given specialized syntax type.
@@ -1102,9 +1096,8 @@ public struct StmtSyntax: StmtSyntaxProtocol, SyntaxHashable {
 
   /// Create a ``StmtSyntax`` node from a specialized syntax node.
   public init(_ syntax: __shared some StmtSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 
@@ -1117,9 +1110,8 @@ public struct StmtSyntax: StmtSyntaxProtocol, SyntaxHashable {
   }
 
   public init(fromProtocol syntax: __shared StmtSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 
@@ -1238,7 +1230,7 @@ public protocol TypeSyntaxProtocol: SyntaxProtocol {}
 /// These methods enable casting between syntax node types within the same
 /// base node protocol hierarchy (e.g., ``DeclSyntaxProtocol``).
 ///
-/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``, 
+/// While ``SyntaxProtocol`` offers general casting methods (``SyntaxProtocol.as(_:)``,
 /// ``SyntaxProtocol.is(_:)``, and ``SyntaxProtocol.cast(_:)``), these often aren't
 /// appropriate for use on types conforming to a specific base node protocol
 /// like ``TypeSyntaxProtocol``. That's because at this level,
@@ -1247,7 +1239,7 @@ public protocol TypeSyntaxProtocol: SyntaxProtocol {}
 ///
 /// To guide developers toward correct usage, this extension provides overloads
 /// of these casting methods that are restricted to the same base node type.
-/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as 
+/// Furthermore, it marks the inherited casting methods from ``SyntaxProtocol`` as
 /// deprecated, indicating that they will always fail when used in this context.
 extension TypeSyntaxProtocol {
   /// Checks if the current syntax node can be cast to a given specialized syntax type.
@@ -1390,9 +1382,8 @@ public struct TypeSyntax: TypeSyntaxProtocol, SyntaxHashable {
 
   /// Create a ``TypeSyntax`` node from a specialized syntax node.
   public init(_ syntax: __shared some TypeSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 
@@ -1405,9 +1396,8 @@ public struct TypeSyntax: TypeSyntaxProtocol, SyntaxHashable {
   }
 
   public init(fromProtocol syntax: __shared TypeSyntaxProtocol) {
-    // We know this cast is going to succeed. Go through init(_: SyntaxData)
-    // to do a sanity check and verify the kind matches in debug builds and get
-    // maximum performance in release builds.
+    // We know this cast is going to succeed. Go through `init(_: SyntaxData)` just to double-check and
+    // verify the kind matches in debug builds and get maximum performance in release builds.
     self = Syntax(syntax).cast(Self.self)
   }
 

SwiftParserCLI/Sources/swift-parser-cli/Commands/Reduce.swift

@@ -97,7 +97,7 @@ struct Reduce: ParsableCommand {
         #if os(Windows)
         _ = TerminateProcess(process.processHandle, 0)
         #else
-        kill(pid_t(process.processIdentifier), SIGKILL)
+        kill(pid_t(process.processIdentifier), SIGKILL)  // ignore-unacceptable-language
         #endif
         return .timeout
       }