Skip to content

Commit 927ed65

Browse files
committed
Remove ValueGenerics feature from swift-syntax
1 parent 4ed73b1 commit 927ed65

File tree

10 files changed

+25
-105
lines changed

10 files changed

+25
-105
lines changed

Diff for: CodeGeneration/Sources/SyntaxSupport/ExperimentalFeatures.swift

-5
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ public enum ExperimentalFeature: String, CaseIterable {
1919
case nonescapableTypes
2020
case trailingComma
2121
case coroutineAccessors
22-
case valueGenerics
2322
case abiAttribute
2423
case keypathWithMethodMembers
2524
case oldOwnershipOperatorSpellings
@@ -40,8 +39,6 @@ public enum ExperimentalFeature: String, CaseIterable {
4039
return "TrailingComma"
4140
case .coroutineAccessors:
4241
return "CoroutineAccessors"
43-
case .valueGenerics:
44-
return "ValueGenerics"
4542
case .abiAttribute:
4643
return "ABIAttribute"
4744
case .keypathWithMethodMembers:
@@ -68,8 +65,6 @@ public enum ExperimentalFeature: String, CaseIterable {
6865
return "trailing commas"
6966
case .coroutineAccessors:
7067
return "coroutine accessors"
71-
case .valueGenerics:
72-
return "value generics"
7368
case .abiAttribute:
7469
return "@abi attribute"
7570
case .keypathWithMethodMembers:

Diff for: CodeGeneration/Sources/SyntaxSupport/GenericNodes.swift

+2-4
Original file line numberDiff line numberDiff line change
@@ -341,8 +341,7 @@ public let GENERIC_NODES: [Node] = [
341341
),
342342
Child(
343343
name: "expr",
344-
kind: .node(kind: .expr),
345-
experimentalFeature: .valueGenerics
344+
kind: .node(kind: .expr)
346345
),
347346
]),
348347
nameForDiagnostics: "left-hand type",
@@ -362,8 +361,7 @@ public let GENERIC_NODES: [Node] = [
362361
),
363362
Child(
364363
name: "expr",
365-
kind: .node(kind: .expr),
366-
experimentalFeature: .valueGenerics
364+
kind: .node(kind: .expr)
367365
),
368366
]),
369367
nameForDiagnostics: "right-hand type",

Diff for: CodeGeneration/Sources/SyntaxSupport/TypeNodes.swift

+1-2
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,7 @@ public let TYPE_NODES: [Node] = [
264264
),
265265
Child(
266266
name: "expr",
267-
kind: .node(kind: .expr),
268-
experimentalFeature: .valueGenerics
267+
kind: .node(kind: .expr)
269268
),
270269
]),
271270
documentation:

Diff for: Sources/SwiftParser/Types.swift

-6
Original file line numberDiff line numberDiff line change
@@ -1233,12 +1233,6 @@ extension Parser {
12331233

12341234
extension Parser {
12351235
mutating func parseValueType() -> RawExprSyntax? {
1236-
// If the 'ValueGenerics' experimental feature hasn't been added, then don't
1237-
// attempt to parse values as types.
1238-
guard self.experimentalFeatures.contains(.valueGenerics) else {
1239-
return nil
1240-
}
1241-
12421236
// Eat any '-' preceding integer literals.
12431237
var minusSign: RawTokenSyntax? = nil
12441238
if self.atContextualPunctuator("-"),

Diff for: Sources/SwiftParser/generated/ExperimentalFeatures.swift

+3-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: Sources/SwiftSyntax/generated/raw/RawSyntaxNodesGHI.swift

-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: Sources/SwiftSyntax/generated/raw/RawSyntaxNodesQRS.swift

-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesGHI.swift

-10
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: Sources/SwiftSyntax/generated/syntaxNodes/SyntaxNodesQRS.swift

-20
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)