AutodiffClosureSpecialization: workaround a problem with OSSA.

eeckstein · eeckstein · commit 09f6f4f9b608 · 2025-01-23T16:10:32.000+01:00
Disable the closure specializer optimization for closures in OSSA until the underlying problem is fixed. #78847 Part of rdar://140229560
diff --git a/SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ClosureSpecialization.swift b/SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ClosureSpecialization.swift
@@ -503,6 +503,12 @@ private func handleApplies(for rootClosure: SingleValueInstruction, callSiteMap:
       continue
     }
 
+    // Workaround for a problem with OSSA: https://github.com/swiftlang/swift/issues/78847
+    // TODO: remove this if-statement once the underlying problem is fixed.
+    if callee.hasOwnership {
+      continue
+    }
+
     if callee.isDefinedExternally {
       continue
     }

Original file line number	Diff line number	Diff line change
`@@ -503,6 +503,12 @@ private func handleApplies(for rootClosure: SingleValueInstruction, callSiteMap:`
`503`	`503`	`continue`
`504`	`504`	`}`
`505`	`505`
	`506`	`+ // Workaround for a problem with OSSA: https://github.com/swiftlang/swift/issues/78847`
	`507`	`+ // TODO: remove this if-statement once the underlying problem is fixed.`
	`508`	`+ if callee.hasOwnership {`
	`509`	`+ continue`
	`510`	`+ }`
	`511`	`+`
`506`	`512`	`if callee.isDefinedExternally {`
`507`	`513`	`continue`
`508`	`514`	`}`