Merge pull request #80279 from DougGregor/stdlib-remaining-memory-safety-warnings

[Standard library] Address remaining memory-safety warnings

Author: DougGregor

stdlib/public/core/Dictionary.swift

@@ -1388,7 +1388,7 @@ extension Dictionary {
         return true
       }
 #else
-      if unsafe lhs._variant.asNative._storage === rhs._variant.asNative._storage {
+      if lhs._variant.asNative._storage === rhs._variant.asNative._storage {
         return true
       }
 #endif

stdlib/public/core/DictionaryBridging.swift

@@ -360,7 +360,7 @@ final internal class _SwiftDeferredNSDictionary<Key: Hashable, Value>
     defer { _fixLifetime(self) }
 
     var stop: UInt8 = 0
-    for bucket in unsafe native.hashTable {
+    for unsafe bucket in unsafe native.hashTable {
       let key = unsafe _key(at: bucket, bridgedKeys: bridgedKeys)
       let value = unsafe _value(at: bucket, bridgedValues: bridgedValues)
       unsafe block(

stdlib/public/core/EmbeddedPrint.swift

@@ -64,13 +64,13 @@ public func print(_ object: some CustomStringConvertible, terminator: StaticStri
 }
 
 func print(_ buf: UnsafeBufferPointer<UInt8>, terminator: StaticString = "\n") {
-  for c in buf {
+  for unsafe c in unsafe buf {
     putchar(CInt(c))
   }
   var p = unsafe terminator.utf8Start
   while unsafe p.pointee != 0 {
     unsafe putchar(CInt(p.pointee))
-    p += 1
+    unsafe p += 1
   }
 }
 

stdlib/public/core/Equatable.swift

@@ -270,6 +270,7 @@ public func === (lhs: AnyObject?, rhs: AnyObject?) -> Bool {
 }
 #else
 @inlinable // trivial-implementation
+@safe
 public func ===<T: AnyObject, U: AnyObject>(lhs: T?, rhs: U?) -> Bool {
   switch (lhs, rhs) {
   case let (l?, r?):

stdlib/public/core/Hashing.swift

@@ -142,7 +142,7 @@ internal final class __BridgingHashBuffer
   }
 
   deinit {
-    for bucket in unsafe header.hashTable {
+    for unsafe bucket in unsafe header.hashTable {
       unsafe (firstElementAddress + bucket.offset).deinitialize(count: 1)
     }
     unsafe _fixLifetime(self)

stdlib/public/core/NativeDictionary.swift

@@ -657,7 +657,7 @@ extension _NativeDictionary where Value: Equatable {
     if self.count != other.count { return false }
 
     defer { _fixLifetime(self) }
-    for bucket in unsafe self.hashTable {
+    for unsafe bucket in unsafe self.hashTable {
       let key = self.uncheckedKey(at: bucket)
       let value = self.uncheckedValue(at: bucket)
       guard

stdlib/public/core/NativeSet.swift

@@ -502,7 +502,7 @@ extension _NativeSet {
     if self.count != other.count { return false }
 
     defer { _fixLifetime(self) }
-    for bucket in unsafe self.hashTable {
+    for unsafe bucket in unsafe self.hashTable {
       let key = self.uncheckedElement(at: bucket)
       let bridgedKey = _bridgeAnythingToObjectiveC(key)
       guard other.contains(bridgedKey) else { return false }

stdlib/public/core/RuntimeFunctionCounters.swift

@@ -521,7 +521,7 @@ func _measureRuntimeFunctionCountersDiffs(
       _RuntimeFunctionCounters.disableRuntimeFunctionCountersUpdates()
     let globalCountersBefore = _GlobalRuntimeFunctionCountersState()
     var objectsCountersBefore: [_ObjectRuntimeFunctionCountersState] = []
-    for object in unsafe objects {
+    for unsafe object in unsafe objects {
       unsafe objectsCountersBefore.append(_ObjectRuntimeFunctionCountersState(object))
     }
     // Enable counters updates.
@@ -535,7 +535,7 @@ func _measureRuntimeFunctionCountersDiffs(
 
     let globalCountersAfter = _GlobalRuntimeFunctionCountersState()
     var objectsCountersDiff: [_ObjectRuntimeFunctionCountersState] = []
-    for (idx, object) in unsafe objects.enumerated() {
+    for unsafe (idx, object) in unsafe objects.enumerated() {
       let objectCountersAfter = unsafe _ObjectRuntimeFunctionCountersState(object)
       objectsCountersDiff.append(
         objectsCountersBefore[idx].diff(objectCountersAfter))

stdlib/public/core/SetBridging.swift

@@ -197,7 +197,7 @@ final internal class _SwiftDeferredNSSet<Element: Hashable>
     let bridged = unsafe __BridgingHashBuffer.allocate(
       owner: native._storage,
       hashTable: native.hashTable)
-    for bucket in unsafe native.hashTable {
+    for unsafe bucket in unsafe native.hashTable {
       let object = _bridgeAnythingToObjectiveC(
         native.uncheckedElement(at: bucket))
       unsafe bridged.initialize(at: bucket, to: object)