Skip to content

Commit bafbfa2

Browse files
committed
[build-script] Remove ninja host
The ninja builder took a host argument that was unused by the function. The ninja build failed to pass this argument, resulting in an execution failure. Removing the argument.
1 parent 90340a0 commit bafbfa2

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

utils/swift_build_support/swift_build_support/products/ninja.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ def is_before_build_script_impl_product(cls):
3232
return False
3333

3434
@classmethod
35-
def new_builder(cls, args, toolchain, workspace, host):
35+
def new_builder(cls, args, toolchain, workspace):
3636
return NinjaBuilder(cls, args, toolchain, workspace)
3737

3838

utils/swift_build_support/tests/products/test_ninja.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,7 @@ def test_ninja_bin_path(self):
7171
ninja_build = Ninja.new_builder(
7272
args=self.args,
7373
toolchain=self.toolchain,
74-
workspace=self.workspace,
75-
host=self.host)
74+
workspace=self.workspace)
7675

7776
self.assertEqual(ninja_build.ninja_bin_path,
7877
os.path.join(
@@ -83,8 +82,7 @@ def test_build(self):
8382
ninja_build = Ninja.new_builder(
8483
args=self.args,
8584
toolchain=self.toolchain,
86-
workspace=self.workspace,
87-
host=self.host)
85+
workspace=self.workspace)
8886

8987
ninja_build.build()
9088

0 commit comments

Comments
 (0)