Skip to content

Commit d2d5925

Browse files
committed
Disable building Ninja tests
Ninja builds its tests by default. We don't run the Ninja test suite, we aren't doing development on Ninja, and we are using a release tag that has been verified to work. There isn't much point in building the tests if we're not going to use them. Disabling building the Ninja tests. If it is desirable to build them, one can set `BUILD_TESTING` to `YES` and re-run their build.
1 parent 203ad94 commit d2d5925

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

utils/swift_build_support/swift_build_support/products/ninja.py

+1
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ def build(self):
5757
"-S", self.source_dir,
5858
"-B", self.build_dir,
5959
"-DCMAKE_BUILD_TYPE=Release",
60+
"-DBUILD_TESTING=OFF",
6061
f"-DCMAKE_C_COMPILER={self.toolchain.cc}",
6162
f"-DCMAKE_CXX_COMPILER={self.toolchain.cxx}"])
6263
shell.call([self.toolchain.cmake, "--build", self.build_dir])

utils/swift_build_support/tests/products/test_ninja.py

+1
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ def test_build(self):
9393
-S {self.workspace.source_dir('ninja')} \
9494
-B {self.workspace.build_dir('build', 'ninja')} \
9595
-DCMAKE_BUILD_TYPE=Release \
96+
-DBUILD_TESTING=OFF \
9697
-DCMAKE_C_COMPILER=/path/to/cc \
9798
-DCMAKE_CXX_COMPILER=/path/to/cxx
9899
+ {self.toolchain.cmake} --build {self.workspace.build_dir('build', 'ninja')}

0 commit comments

Comments
 (0)