Skip to content

SIL verification failed: A load with trivial ownership must load a trivial type: LI->getType().isTrivial(*LI->getFunction()) #79491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hjyamauchi opened this issue Feb 19, 2025 · 6 comments
Closed

SIL verification failed: A load with trivial ownership must load a trivial type: LI->getType().isTrivial(*LI->getFunction()) #79491

hjyamauchi opened this issue Feb 19, 2025 · 6 comments
Assignees
@eeckstein
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. crash Bug: A crash, i.e., an abnormal termination of software macOS Platform: macOS SIL ownership Area → compiler → SIL: SIL ownership SIL Windows Platform: Windows

Comments

@hjyamauchi
Copy link
Contributor

hjyamauchi commented Feb 19, 2025 •
edited
Loading

Description

The main branch toolchain build started to crash around Feb 16, 2025 with a SIL verification failure when building swift-syntax in release mode in our Windows CI.

error: compile command failed due to signal 6 (use -v to see invocation)
SIL verification failed: A load with trivial ownership must load a trivial type: LI->getType().isTrivial(*LI->getFunction())
Verifying instruction:
     %29 = struct_element_addr %24 : $*Repro.Iterator, #Repro.Iterator.nxt // users: %73, %35, %42, %49, %31, %30
->   %35 = load [trivial] %29 : $*Optional<String> // user: %37
     br bb1(%23 : $Builtin.Int64, %12 : $Builtin.RawPointer, %6 : $__ContiguousArrayStorageBase, %35 : $Optional<String>) // id: %37
In function:
// specialized _copySequenceToContiguousArray<A>(_:)

Reproduction

A reduced test

swiftc Repro.swift -O -enable-library-evolution

e.g., https://download.swift.org/development/xcode/swift-DEVELOPMENT-SNAPSHOT-2025-02-18-a/swift-DEVELOPMENT-SNAPSHOT-2025-02-18-a-osx.pkg

Repro.swift

public struct Repro: Sequence {
  public struct Iterator: IteratorProtocol {
    var nxt: String?
    let start: String

    init(_ token: String?, _ start: String) {
      self.nxt = token
      self.start = start
    }

    public mutating func next() -> String? {
      guard let token = self.nxt else { return nil }
      self.nxt = token
      if self.nxt != nil {
        self.nxt = nil
      }
      return token
    }
  }

  let pos: String

  public init(_ pos: String) {
    self.pos = pos
  }

  public func makeIterator() -> Iterator {
    return Iterator(nil, pos)
  }
}

Stack dump

On macOS

Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.
Stack dump:
0.	Program arguments: /Users/hiroshi/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2025-02-18-a.xctoolchain/usr/bin/swift-frontend -frontend -c -primary-file Repro.swift -target arm64-apple-macosx15.0 -Xllvm -aarch64-use-tbi -enable-objc-interop -color-diagnostics -enable-library-evolution -O -resource-dir /Users/hiroshi/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2025-02-18-a.xctoolchain/usr/lib/swift -no-auto-bridging-header-chaining -module-name Repro -in-process-plugin-server-path /Users/hiroshi/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2025-02-18-a.xctoolchain/usr/lib/swift/host/libSwiftInProcPluginServer.dylib -plugin-path /Users/hiroshi/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2025-02-18-a.xctoolchain/usr/lib/swift/host/plugins -plugin-path /Users/hiroshi/Library/Developer/Toolchains/swift-DEVELOPMENT-SNAPSHOT-2025-02-18-a.xctoolchain/usr/local/lib/swift/host/plugins -o /var/folders/ww/kxcj3hm12kd92gcwr9t3y7k40000gq/T/TemporaryDirectory.NTLNHO/Repro-1.o
1.	Apple Swift version 6.2-dev (LLVM 23dd6ab259a178a, Swift a4a3a41b50e111e)
2.	Compiling with effective version 5.10
3.	While evaluating request ExecuteSILPipelineRequest(Run pipelines { PrepareOptimizationPasses, EarlyModulePasses, HighLevel,Function+EarlyLoopOpt, HighLevel,Module+StackPromote, MidLevel,Function, ClosureSpecialize, LowLevel,Function, LateLoopOpt, SIL Debug Info Generator } on SIL for Repro)
4.	While running pass #3948 SILFunctionTransform "OwnershipModelEliminator" on SILFunction "@$ss30_copySequenceToContiguousArrayys0dE0Vy7ElementQzGxSTRzlF5ReproAGV_TB5".
 for <<debugloc at "<compiler-generated>":0:0>>5.	Found verification error when verifying before lowering ownership. Please re-run with -sil-verify-all to identify the actual pass that introduced the verification error.
6.	While verifying SIL function "@$ss30_copySequenceToContiguousArrayys0dE0Vy7ElementQzGxSTRzlF5ReproAGV_TB5".
 for <<debugloc at "<compiler-generated>":0:0>>Stack dump without symbol names (ensure you have llvm-symbolizer in your PATH or set the environment var `LLVM_SYMBOLIZER_PATH` to point to it):
0  swift-frontend           0x0000000108bfa948 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) + 56
1  swift-frontend           0x0000000108bf902c llvm::sys::RunSignalHandlers() + 112
2  swift-frontend           0x0000000108bfafa0 SignalHandler(int, __siginfo*, void*) + 300
3  libsystem_platform.dylib 0x00000001954a2de4 _sigtramp + 56
4  libsystem_pthread.dylib  0x000000019546bf70 pthread_kill + 288
5  libsystem_c.dylib        0x0000000195378908 abort + 128
6  swift-frontend           0x0000000103d01fc4 swift::SILModule::print(llvm::raw_ostream&, swift::ModuleDecl*, swift::SILOptions const&, bool) const + 0
7  swift-frontend           0x0000000103d0a254 swift::SILVisitorBase<(anonymous namespace)::SILVerifier, void>::visitSILBasicBlock(swift::SILBasicBlock*) + 1312
8  swift-frontend           0x0000000103d09c34 (anonymous namespace)::SILVerifier::visitSILBasicBlock(swift::SILBasicBlock*) + 28
9  swift-frontend           0x0000000103d0839c (anonymous namespace)::SILVerifier::visitSILFunction(swift::SILFunction*) + 10844
10 swift-frontend           0x0000000103d0217c swift::SILFunction::verify(swift::CalleeCache*, bool, bool, bool) const + 224
11 swift-frontend           0x000000010373fdc4 (anonymous namespace)::OwnershipModelEliminator::run() + 268
12 swift-frontend           0x00000001037471e0 swift::SILPassManager::runPassOnFunction(unsigned int, swift::SILFunction*) + 1432
13 swift-frontend           0x0000000103748114 swift::SILPassManager::runFunctionPasses(unsigned int, unsigned int) + 1060
14 swift-frontend           0x00000001037450d8 swift::SILPassManager::executePassPipelinePlan(swift::SILPassPipelinePlan const&) + 72
15 swift-frontend           0x0000000103745058 swift::ExecuteSILPipelineRequest::evaluate(swift::Evaluator&, swift::SILPipelineExecutionDescriptor) const + 68
16 swift-frontend           0x0000000103795c10 swift::SimpleRequest<swift::ExecuteSILPipelineRequest, std::__1::tuple<> (swift::SILPipelineExecutionDescriptor), (swift::RequestFlags)1>::evaluateRequest(swift::ExecuteSILPipelineRequest const&, swift::Evaluator&) + 28
17 swift-frontend           0x00000001037621e4 swift::ExecuteSILPipelineRequest::OutputType swift::Evaluator::getResultUncached<swift::ExecuteSILPipelineRequest, swift::ExecuteSILPipelineRequest::OutputType swift::evaluateOrFatal<swift::ExecuteSILPipelineRequest>(swift::Evaluator&, swift::ExecuteSILPipelineRequest)::'lambda'()>(swift::ExecuteSILPipelineRequest const&, swift::ExecuteSILPipelineRequest::OutputType swift::evaluateOrFatal<swift::ExecuteSILPipelineRequest>(swift::Evaluator&, swift::ExecuteSILPipelineRequest)::'lambda'()) + 204
18 swift-frontend           0x00000001037452b4 swift::executePassPipelinePlan(swift::SILModule*, swift::SILPassPipelinePlan const&, bool, swift::irgen::IRGenModule*) + 64
19 swift-frontend           0x0000000103777f58 swift::runSILOptimizationPasses(swift::SILModule&) + 156
20 swift-frontend           0x0000000102f217e4 swift::CompilerInstance::performSILProcessing(swift::SILModule*) + 636
21 swift-frontend           0x0000000102ccdfac performCompileStepsPostSILGen(swift::CompilerInstance&, std::__1::unique_ptr<swift::SILModule, std::__1::default_delete<swift::SILModule>>, llvm::PointerUnion<swift::ModuleDecl*, swift::SourceFile*>, swift::PrimarySpecificPaths const&, int&, swift::FrontendObserver*) + 820
22 swift-frontend           0x0000000102ccd630 swift::performCompileStepsPostSema(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 656
23 swift-frontend           0x0000000102cd9828 withSemanticAnalysis(swift::CompilerInstance&, swift::FrontendObserver*, llvm::function_ref<bool (swift::CompilerInstance&)>, bool) + 160
24 swift-frontend           0x0000000102ccf344 performCompile(swift::CompilerInstance&, int&, swift::FrontendObserver*) + 716
25 swift-frontend           0x0000000102cceb60 swift::performFrontend(llvm::ArrayRef<char const*>, char const*, void*, swift::FrontendObserver*) + 2216
26 swift-frontend           0x0000000102a8904c swift::mainEntry(int, char const**) + 3100
27 dyld                     0x00000001950ec274 start + 2840

On Windows

Please submit a bug report (https://swift.org/contributing/#reporting-bugs) and include the crash backtrace.
Stack dump:
0.      Program arguments: C:\\Users\\hiroshi\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\bin\\swift-frontend.exe -frontend -c -primary-file C:\\Users\\hiroshi\\tmp\\repro.swift -target x86_64-unknown-windows-msvc -disable-objc-interop -sdk C:\\Users\\hiroshi\\AppData\\Local\\Programs\\Swift\\Platforms\\0.0.0\\Windows.platform\\Developer\\SDKs\\Windows.sdk\\ -color-diagnostics -enable-library-evolution -O -resource-dir C:\\Users\\hiroshi\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\lib\\swift -no-auto-bridging-header-chaining -module-name repro -in-process-plugin-server-path C:\\Users\\hiroshi\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\bin\\SwiftInProcPluginServer.dll -plugin-path C:\\Users\\hiroshi\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\bin -plugin-path C:\\Users\\hiroshi\\AppData\\Local\\Programs\\Swift\\Toolchains\\0.0.0+Asserts\\usr\\local\\bin -o C:\\Users\\hiroshi\\AppData\\Local\\Temp\\TemporaryDirectory.WxsE8i\\repro-1.o
1.      compnerd.org Swift version 6.2-dev (LLVM 8bdbd74d77951ad, Swift 63b7f05d749d48f)
2.      Compiling with effective version 5.10
3.      While evaluating request ExecuteSILPipelineRequest(Run pipelines { PrepareOptimizationPasses, EarlyModulePasses, HighLevel,Function+EarlyLoopOpt, HighLevel,Module+StackPromote, MidLevel,Function, ClosureSpecialize, LowLevel,Function, LateLoopOpt, SIL Debug Info Generator } on SIL for repro)
4.      While running pass #3823 SILFunctionTransform "OwnershipModelEliminator" on SILFunction "@$ss30_copySequenceToContiguousArrayys0dE0Vy7ElementQzGxSTRzlF5repro5ReproV_TB5".
 for <<debugloc at "<compiler-generated>":0:0>>5.       Found verification error when verifying before lowering ownership. Please re-run with -sil-verify-all to identify the actual pass that introduced the verification error.
6.      While verifying SIL function "@$ss30_copySequenceToContiguousArrayys0dE0Vy7ElementQzGxSTRzlF5repro5ReproV_TB5".
 for <<debugloc at "<compiler-generated>":0:0>>Exception Code: 0x80000003
 #0 0x00007ff68067a825 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x6dea825)
 #1 0x00007fff47241ae9 (C:\WINDOWS\System32\ucrtbase.dll+0xc1ae9)
 #2 0x00007fff47224c11 (C:\WINDOWS\System32\ucrtbase.dll+0xa4c11)
 #3 0x00007ff67af478eb (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x16b78eb)
 #4 0x00007ff67af328f8 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x16a28f8)
 #5 0x00007ff67af52395 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x16c2395)
 #6 0x00007ff67af56bdb (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x16c6bdb)
 #7 0x00007ff67af5734f (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x16c734f)
 #8 0x00007ff67af47a1c (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x16b7a1c)
 #9 0x00007ff67aa5ffb3 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x11cffb3)
#10 0x00007ff67a75312d (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0xec312d)
#11 0x00007ff67a752337 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0xec2337)
#12 0x00007ff67a74b867 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0xebb867)
#13 0x00007ff67a74bb46 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0xebbb46)
#14 0x00007ff67a74b557 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0xebb557)
#15 0x00007ff67a7a202d (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0xf1202d)
#16 0x00007ff67a74bcdf (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0xebbcdf)
#17 0x00007ff67a734eb5 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0xea4eb5)
#18 0x00007ff67a134565 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x8a4565)
#19 0x00007ff679e9d87d (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x60d87d)
#20 0x00007ff679e9e35f (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x60e35f)
#21 0x00007ff679e9d0c4 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x60d0c4)
#22 0x00007ff679e9d57b (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x60d57b)
#23 0x00007ff679e9f444 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x60f444)
#24 0x00007ff679cee310 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x45e310)
#25 0x00007ff679ceddd7 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x45ddd7)
#26 0x00007ff6806d9914 (C:\Users\hiroshi\AppData\Local\Programs\Swift\Toolchains\0.0.0+Asserts\usr\bin\swift-frontend.exe+0x6e49914)
#27 0x00007fff48f1e8d7 (C:\WINDOWS\System32\KERNEL32.DLL+0x2e8d7)
#28 0x00007fff4975bf2c (C:\WINDOWS\SYSTEM32\ntdll.dll+0xbbf2c)

Expected behavior

No compiler crash

Environment

macOS and Windows

Additional information

No response
@hjyamauchi hjyamauchi added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. crash Bug: A crash, i.e., an abnormal termination of software triage needed This issue needs more specific labels Windows Platform: Windows macOS Platform: macOS labels Feb 19, 2025
@compnerd compnerd added SIL SIL ownership Area → compiler → SIL: SIL ownership labels Feb 19, 2025
@compnerd
Copy link
Member

CC: @ahoppen @gottesmm

@hjyamauchi
Copy link
Contributor Author

This seems like a recent regression since around 2025-02-14.

@hborla hborla removed the triage needed This issue needs more specific labels label Feb 22, 2025
@hjyamauchi
Copy link
Contributor Author

My local bisecting points to the PR #79186

I can reproduce this failure at commit c4af3b3 with the following repo snapshot

swift_argument_parser_revision=0fbc8848e389af3bb55c182bc19ca9d5dc2f255b
swift_asn1_revision=12c24ff59d541e5ef15116095445ce72b85cd0c6
swift_atomics_revision=cd142fd2f64be2100422d658e7411e39489da985
swift_certificates_revision=01d7664523af5c169f26038f1e5d444ce47ae5ff
swift_collections_revision=9bf03ff58ce34478e66aaee630e491823326fd06
swift_corelibs_libdispatch_revision=58fc9c59a7e0be92696850dd2fb9bd539bbc2de4
swift_crypto_revision=629f0b679d0fd0a6ae823d7f750b9ab032c00b80
swift_nio_revision=c51907a839e63ebf0ba2076bba73dd96436bd1b9
swift_system_revision=f9266c85189c2751589a50ea5aec72799797e471
ds2_revision=52d127802ea2e83287b7d48b7b73b7dff2bd4246
swift_build_revision=701485b2f0761796ae68e7af78d84b811ca51cac
swift_win32_revision=45a9e4e83cef6ffeef0509c34452d648e88d8eb6
curl_revision=83bedbd730d62b83744cc26fa0433d3f6e2e4cd6
libxml2_revision=2b998a4ffbdfea04fc6a620721abc690a15743af
zlib_revision=51b7f2abdade71cd9bb0e7a373ef2610ec6f9daf
mimalloc_revision=e14cfd2578fd68205b8d38895abe120bb622580e
indexstore_db_revision=e08105badfbea2ff27cc4519c4ebb287b91c3cb8
llvm_project_revision=5e1f334a6b85c74e214d58344a71a95671a55586
sourcekit_lsp_revision=d5978d5f8c6c32ab50f8265a53caff3defe4952e
swift_revision=c4af3b3a8eaacb28c91e31781894938d9d86f76b
swift_build_revision=3abb03cddaf2fa8ab66730370e51abb7ff9bcb57
swift_cmark_revision=b022b08312decdc46585e0b3440d97f6f22ef703
swift_corelibs_foundation_revision=0129358ceac4e587b6340a52977ea75f8b4601d5
swift_corelibs_xctest_revision=d7e4406feffb4a71878de8847ee689a8986872c8
swift_docc_revision=d5bf7a5257f897a1e7d4ce80eab93ccd8ad16b33
swift_docc_plugin_revision=3303b164430d9a7055ba484c8ead67a52f7b74f6
swift_docc_render_revision=53cfd22f21e453b7a77a9201f6b78ae0cc4642f7
swift_docc_render_artifact_revision=1fe16ced571e6e2a359a695d6ee46f3c52e360f2
swift_docc_symbolkit_revision=b2eeb98a5f75413f77a159002ac2666361c4ec00
swift_driver_revision=57caff8b62cc33e9e47b7cdab3c9a03778e8ebf8
swift_experimental_string_processing_revision=f27be255b973f718801b6f8c4a005ea5b793f38f
swift_format_revision=2f71242f4c86a7773fdf3e8403c26d3d70b146f6
swift_foundation_revision=74275a96e87170eab064bf720367ca8e63150cbb
swift_foundation_icu_revision=7e255a994ec26a08214f8fea2fdaf60b296e1f22
swift_installer_scripts_revision=8d82c7bd1799b7a9c214cd48d29471a20424e071
swift_llbuild_revision=31959bebb0a86a02d60daf2d1cec817795a37a04
swift_lmdb_revision=29e6ac814f4f5138576bcb3d3995ed900aa8714e
swift_markdown_revision=e62a44fd1f2764ba8807db3b6f257627449bbb8c
swift_package_manager_revision=6a425f47ea6895cd2857b045a3dcd003339f989a
swift_syntax_revision=1c0e46a29623526883780f2c7dfe7efae318afa2
swift_testing_revision=63eb1d97e305befeea9cee3482a9ce38507a2cf6
swift_toolchain_sqlite_revision=a911e64716e2dbf7ebcedfa0299039eee9702e33
swift_tools_support_core_revision=bd9e2de5fdada4a0249de3be88f9ad95fe8511f6

but cannot at the previous commit 1c1570b with the repo snapshot

swift_argument_parser_revision=0fbc8848e389af3bb55c182bc19ca9d5dc2f255b
swift_asn1_revision=12c24ff59d541e5ef15116095445ce72b85cd0c6
swift_atomics_revision=cd142fd2f64be2100422d658e7411e39489da985
swift_certificates_revision=01d7664523af5c169f26038f1e5d444ce47ae5ff
swift_collections_revision=9bf03ff58ce34478e66aaee630e491823326fd06
swift_corelibs_libdispatch_revision=58fc9c59a7e0be92696850dd2fb9bd539bbc2de4
swift_crypto_revision=629f0b679d0fd0a6ae823d7f750b9ab032c00b80
swift_nio_revision=c51907a839e63ebf0ba2076bba73dd96436bd1b9
swift_system_revision=f9266c85189c2751589a50ea5aec72799797e471
ds2_revision=52d127802ea2e83287b7d48b7b73b7dff2bd4246
swift_build_revision=701485b2f0761796ae68e7af78d84b811ca51cac
swift_win32_revision=45a9e4e83cef6ffeef0509c34452d648e88d8eb6
curl_revision=83bedbd730d62b83744cc26fa0433d3f6e2e4cd6
libxml2_revision=2b998a4ffbdfea04fc6a620721abc690a15743af
zlib_revision=51b7f2abdade71cd9bb0e7a373ef2610ec6f9daf
mimalloc_revision=e14cfd2578fd68205b8d38895abe120bb622580e
indexstore_db_revision=e08105badfbea2ff27cc4519c4ebb287b91c3cb8
llvm_project_revision=f29572acf156950ae710ee59c360956e987b15b4
sourcekit_lsp_revision=d5978d5f8c6c32ab50f8265a53caff3defe4952e
swift_revision=1c1570b5f6ffa5e26f62ebb01f2d4b0973f80f00
swift_build_revision=3abb03cddaf2fa8ab66730370e51abb7ff9bcb57
swift_cmark_revision=b022b08312decdc46585e0b3440d97f6f22ef703
swift_corelibs_foundation_revision=0129358ceac4e587b6340a52977ea75f8b4601d5
swift_corelibs_xctest_revision=d7e4406feffb4a71878de8847ee689a8986872c8
swift_docc_revision=d5bf7a5257f897a1e7d4ce80eab93ccd8ad16b33
swift_docc_plugin_revision=3303b164430d9a7055ba484c8ead67a52f7b74f6
swift_docc_render_revision=53cfd22f21e453b7a77a9201f6b78ae0cc4642f7
swift_docc_render_artifact_revision=1fe16ced571e6e2a359a695d6ee46f3c52e360f2
swift_docc_symbolkit_revision=b2eeb98a5f75413f77a159002ac2666361c4ec00
swift_driver_revision=57caff8b62cc33e9e47b7cdab3c9a03778e8ebf8
swift_experimental_string_processing_revision=f27be255b973f718801b6f8c4a005ea5b793f38f
swift_format_revision=2f71242f4c86a7773fdf3e8403c26d3d70b146f6
swift_foundation_revision=74275a96e87170eab064bf720367ca8e63150cbb
swift_foundation_icu_revision=7e255a994ec26a08214f8fea2fdaf60b296e1f22
swift_installer_scripts_revision=8d82c7bd1799b7a9c214cd48d29471a20424e071
swift_llbuild_revision=31959bebb0a86a02d60daf2d1cec817795a37a04
swift_lmdb_revision=29e6ac814f4f5138576bcb3d3995ed900aa8714e
swift_markdown_revision=e62a44fd1f2764ba8807db3b6f257627449bbb8c
swift_package_manager_revision=6a425f47ea6895cd2857b045a3dcd003339f989a
swift_syntax_revision=1c0e46a29623526883780f2c7dfe7efae318afa2
swift_testing_revision=63eb1d97e305befeea9cee3482a9ce38507a2cf6
swift_toolchain_sqlite_revision=a911e64716e2dbf7ebcedfa0299039eee9702e33
swift_tools_support_core_revision=bd9e2de5fdada4a0249de3be88f9ad95fe8511f6

or if I revert the PR with git revert -m 1 c4af3b3a8ea from the first snapshot.

@hjyamauchi hjyamauchi mentioned this issue Feb 24, 2025
Merged
@eeckstein eeckstein self-assigned this Feb 25, 2025
@eeckstein
Copy link
Contributor

I'm taking a look

eeckstein added a commit to eeckstein/swift that referenced this issue Feb 25, 2025
@eeckstein
LICM: fix handling of stores of Optional.none in OSSA
bfdeb57 
Currently we don't support hoisting ownership instructions.
But the check was missing a store of Optional.none because such a value has no ownership even if the optional is not trivial.

Fixes a SIL verifier crash.
swiftlang#79491
@eeckstein eeckstein mentioned this issue Feb 25, 2025
Merged
@hjyamauchi
Copy link
Contributor Author

@eeckstein ty!

@hjyamauchi
Copy link
Contributor Author

Fixed with #79604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eeckstein eeckstein

Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. crash Bug: A crash, i.e., an abnormal termination of software macOS Platform: macOS SIL ownership Area → compiler → SIL: SIL ownership SIL Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@compnerd @hborla @eeckstein @hjyamauchi