Concurrency: Explicitly mark Sendable conformance as unavailable for JSValue

kateinoigakukun · kateinoigakukun · commit 3f3b494adf03 · 2025-03-05T08:34:53.000Z
diff --git a/Sources/JavaScriptKit/JSValue.swift b/Sources/JavaScriptKit/JSValue.swift
@@ -100,6 +100,13 @@ public enum JSValue: Equatable {
     }
 }
 
+/// JSValue is intentionally not `Sendable` because accessing a JSValue living in a different
+/// thread is invalid. Although there are some cases where Swift allows sending a non-Sendable
+/// values to other isolation domains, not conforming `Sendable` is still useful to prevent
+/// accidental misuse.
+@available(*, unavailable)
+extension JSValue: Sendable {}
+
 public extension JSValue {
 #if !hasFeature(Embedded)
     /// An unsafe convenience method of `JSObject.subscript(_ name: String) -> ((ConvertibleToJSValue...) -> JSValue)?`

Original file line number	Diff line number	Diff line change
`@@ -100,6 +100,13 @@ public enum JSValue: Equatable {`
`100`	`100`	`}`
`101`	`101`	`}`
`102`	`102`
	`103`	+/// JSValue is intentionally not `Sendable` because accessing a JSValue living in a different
	`104`	`+/// thread is invalid. Although there are some cases where Swift allows sending a non-Sendable`
	`105`	+/// values to other isolation domains, not conforming `Sendable` is still useful to prevent
	`106`	`+/// accidental misuse.`
	`107`	`+@available(*, unavailable)`
	`108`	`+extension JSValue: Sendable {}`
	`109`	`+`
`103`	`110`	`public extension JSValue {`
`104`	`111`	`#if !hasFeature(Embedded)`
`105`	`112`	/// An unsafe convenience method of `JSObject.subscript(_ name: String) -> ((ConvertibleToJSValue...) -> JSValue)?`