Skip to content

Commit 0760cb0

Browse files
coolcshnje
andauthored
Updated docker file to run on local architecture (Azure-Samples#118)
## Purpose The DevContainer was hard coded to use the AMD64 base image which meant it ran emulated on ARM devices. Now it runs on the native architecture of the machine it is running on which makes it faster and solves potential compatibility issues running under the Docker QEMU emulator. ## Does this introduce a breaking change? [ ] Yes [X ] No ## Pull Request Type What kind of change does this Pull Request introduce? [X ] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Documentation content changes [ ] Other... Please describe: ``` ## How to Test * Get the code ``` git clone [repo-address] cd [repo-name] git checkout [branch-name] npm install ``` * Test the code <!-- Add steps to run the tests suite and/or manually test --> ``` ``` ## What to Check Verify that the following are valid * ... ## Other Information <!-- Add any other helpful information that may be needed here. --> --------- Co-authored-by: Scott Hunter <[email protected]>
1 parent 8f293c8 commit 0760cb0

File tree

2 files changed

+4
-27
lines changed

2 files changed

+4
-27
lines changed

.devcontainer/Dockerfile

-11
This file was deleted.

.devcontainer/devcontainer.json

+4-16
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,11 @@
11
{
22
"name": "Azure Developer CLI",
3-
"build": {
4-
"dockerfile": "Dockerfile",
5-
"args": {
6-
"IMAGE": "dotnet",
7-
"VERSION": "7.0",
8-
"VARIANT": "bullseye"
9-
}
10-
},
3+
"image": "mcr.microsoft.com/devcontainers/dotnet:0-7.0-bullseye",
114
"features": {
125
"ghcr.io/devcontainers/features/docker-in-docker:2": {},
13-
"ghcr.io/devcontainers/features/kubectl-helm-minikube:1": {
14-
"version": "latest",
15-
"helm": "latest",
16-
"minikube": "none"
17-
},
18-
"ghcr.io/devcontainers/features/powershell:1.1.0": {},
19-
"ghcr.io/devcontainers/features/azure-cli:1.0.8": {},
20-
"ghcr.io/devcontainers/features/github-cli:1.0.10": {}
6+
"ghcr.io/devcontainers/features/azure-cli:1.1.0": {},
7+
"ghcr.io/devcontainers/features/github-cli:1.0.9": {},
8+
"ghcr.io/azure/azure-dev/azd:latest": {}
219
},
2210
"customizations": {
2311
"vscode": {

0 commit comments

Comments
 (0)