Skip to content

Support HTML as content for the name of an item #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bbrala opened this issue Oct 26, 2015 · 4 comments
Closed

Support HTML as content for the name of an item #302

bbrala opened this issue Oct 26, 2015 · 4 comments
Labels

Comments

@bbrala
Copy link
Member

bbrala commented Oct 26, 2015

As discussed in #252 a way to add HTML as an item that plays nicely with the different item types.

@bbrala bbrala added the Feature label Oct 26, 2015
@arai-a
Copy link
Contributor

arai-a commented Oct 26, 2015

there could be 2 ways to solve it:

  1. Different property for HTML
    If item.html property exists, call .html(item.html) instead of .text(item.name)
  2. Flag property to mark it as HTML
    If item.isHTML property is true, call .html(item.name) instead of .text(item.name)

in both way, property name is just a draft, there could be better name.

The problem is that there is already item.type == 'html' with item.html property for content. It should be nice to make these 2 types clearly distinguishable.

@bbrala bbrala mentioned this issue Mar 13, 2016
@zendre4 zendre4 mentioned this issue Mar 13, 2016
@brassard
Copy link
Contributor

Proposed a PR #388 to address this issue.

@brassard
Copy link
Contributor

I believe that this issue is resolved with the now-merged PR #388.

@bbrala
Copy link
Member Author

bbrala commented May 24, 2016

Yes! :) I went through the issues, but didnt go back enough. Thanks

@bbrala bbrala closed this as completed May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants