Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[translate] Migrate to go-translate v3 #16823

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Conversation

EasternLi
Copy link
Contributor

No description provided.

@bcc32
Copy link
Collaborator

bcc32 commented Feb 15, 2025

This all looks unobjectionable to me but I've never used this layer before. I assume this PR is just updating due to backwards-incompatible changes upstream?

@EasternLi
Copy link
Contributor Author

This all looks unobjectionable to me but I've never used this layer before. I assume this PR is just updating due to backwards-incompatible changes upstream?

yes, some APIs are changed in go-translate v3, and the code for compatibility has been removed

@bcc32 bcc32 merged commit 1fb6a61 into syl20bnr:develop Feb 16, 2025
6 checks passed
@bcc32
Copy link
Collaborator

bcc32 commented Feb 16, 2025

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants