spacemacs/consult-edit does not work on consult-line

[downward-funarg]

Description

According to the docs, spacemacs/consult-edit should immediately enter a state which allows entries to be edited. It doesn't; when I try I get "Text is read-only". read-only-mode is not responsible, since toggling it does nothing.

Reproduction guide 🪲

• Enable compleseus
• Start Emacs
• SPC s s, then type some text and C-c C-e
• try editing any of the entries

Observed behaviour: 👀 💔
<>

Expected behaviour: ❤️ 😄
<>

System Info 💻

• OS: darwin
• Emacs: 30.2
• Spacemacs: 0.999.0
• Spacemacs branch: develop (rev. 4d7c01d)
• Graphic display: t
• Running in daemon: nil
• Distribution: spacemacs
• Editing style: hybrid
• Completion: compleseus
• Layers:

(auto-completion bibtex
                       compleseus csv dape
                       (deft :variables deft-directory "~/notes")
                       emacs-lisp ess git html julia
                       (latex :variables latex-backend 'lsp latex-enable-magic t
                              latex-enable-auto-fill nil
                              latex-view-pdf-in-split-window t
                              latex-view-with-pdf-tools nil)
                       lsp markdown org
                       pdf
                       (python :variables python-backend 'lsp python-formatter
                               'lsp python-lsp-server 'pyright
                               python-shell-interpreter "ipython"
                               python-shell-interpreter-args
                               "-i --simple-prompt" python-virtualenv-management
                               'pet)
                       (shell :variables shell-default-height 30
                              shell-default-position 'bottom
                              shell-default-term-shell "fish"
                              shell-default-shell 'vterm
                              vterm-always-compile-module 't)
                       shell-scripts
                       (spell-checking-jinx :variables
                                            spell-checking-jinx-enable-by-default
                                            nil)
                       (syntax-checking :variables flycheck-indication-mode nil)
                       (version-control :variables version-control-global-margin
                                        t version-control-diff-side 'left
                                        vc-follow-symlinks t)
                       xclipboard)

• System configuration features: ACL GLIB GNUTLS LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM XWIDGETS ZLIB

Backtrace 🐾

<<BACKTRACE IF RELEVANT>>

[bcc32]

Reading the implementation, it seems this only works for grep results and not things like consult-line which SPC s s is bound to. I don't know if there's an easy way to make consult-line compatible with editing (wgrep is specialized to grep buffers) but maybe it could integrate with occur somehow?

[downward-funarg]

It looks like this works (warning: I used AI):

;; Make `consult-line` exports file-backed and wgrep-editable.
(with-eval-after-load 'embark-consult
  (setf (alist-get 'consult-location embark-exporters-alist)
        #'embark-consult-export-location-grep))

(defun spacemacs/grep-change-to-wgrep-mode ()
  "Switch grep buffer to wgrep and show Spacemacs edit keys."
  (interactive)
  (require 'wgrep)
  (wgrep-change-to-wgrep-mode)
  (evil-normal-state)
  (message "Wgrep edit: apply (, c), abort (, k), abort + quit (, q)"))

The second function is only necessary to fix the keybinding display on entering wgrep-mode.

[downward-funarg]

Sorry, this edit as well

(defun spacemacs/consult-edit ()
  "Export the consult buffer and make it editable right away."
  (interactive)
  (require 'embark)
  (let ((after-export-hook
         (lambda ()
           (cond
            ((derived-mode-p 'grep-mode)
             (spacemacs/grep-change-to-wgrep-mode))
            ((derived-mode-p 'occur-mode)
             (occur-edit-mode))))))
    (add-hook 'embark-after-export-hook after-export-hook)
    (unwind-protect
        (embark-export)
      (remove-hook 'embark-after-export-hook after-export-hook))))