Description
The shell-pop package was recently updated(kyagi/shell-pop-el#76) and it removed a variable(shell-pop-last-shell-buffer-name) that spacemacs relies on. This prevents the shell from closing when calling spacemacs/default-pop-shell to close the shell.
Reproduction
- start Emacs
- Call open shell (
SPC ')
- The should be an error message in the Message buffer but it will successfully open the shell
- Call open shell again in the shell buffer (
SPC ')
The buffer will not close and display an error message.
Backtrace
Debugger entered--Lisp error: (void-variable shell-pop-last-buffer)
(buffer-live-p shell-pop-last-buffer)
(if (buffer-live-p shell-pop-last-buffer) nil (setq shell-pop-last-buffer (window-buffer (get-mru-window nil t t))))
spacemacs//shell-pop-restore-window()
shell-pop-out()
shell-pop(nil)
(if (equal '(4) index) (vterm nil) (shell-pop--set-shell-type 'shell-pop-shell-type (list "vterm" (concat "*" (spacemacs//current-layout-name) "-" (if (file-remote-p default-directory) "remote-" "") "vterm" "*") (lambda nil (vterm nil)))) (shell-pop index) (spacemacs/resize-shell-to-desired-width))
spacemacs/shell-pop-vterm(nil)
funcall-interactively(spacemacs/shell-pop-vterm nil)
call-interactively(spacemacs/shell-pop-vterm)
(let ((shell (cond ((eql shell-default-shell 'multi-vterm) 'multivterm) ((eql shell-default-shell 'multi-term) 'multiterm) ((eql shell-default-shell 'shell) 'inferior-shell) (t shell-default-shell)))) (call-interactively (intern (format "spacemacs/shell-pop-%S" shell))))
spacemacs/default-pop-shell()
funcall-interactively(spacemacs/default-pop-shell)
call-interactively(spacemacs/default-pop-shell nil nil)
command-execute(spacemacs/default-pop-shell)
Description
The shell-pop package was recently updated(kyagi/shell-pop-el#76) and it removed a variable(shell-pop-last-shell-buffer-name) that spacemacs relies on. This prevents the shell from closing when calling
spacemacs/default-pop-shellto close the shell.Reproduction
SPC ')SPC ')The buffer will not close and display an error message.
Backtrace