Skip to content

Commit 14377c8

Browse files
feature #59890 [VarExporter] Leverage native lazy objects (nicolas-grekas)
This PR was merged into the 7.3 branch. Discussion ---------- [VarExporter] Leverage native lazy objects | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Let's leverage native lazy objects. Instead of keeping/updating LazyGhostTrait and LazyProxyTrait, I'm deprecating them in favor of using native lazy proxies directly. There is one use case that is not covered by native lazy objects: lazy decorators - aka lazy proxies built against an interface or an internal class. For this use case, we keep `ProxyHelper::generateLazyProxy()`. Commits ------- a00855a4934 [VarExporter] Leverage native lazy objects
2 parents 89633d7 + 68db887 commit 14377c8

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

Tests/Security/User/EntityUserProviderTest.php

+6
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ public function testRefreshInvalidUser()
136136
$provider->refreshUser($user2);
137137
}
138138

139+
/**
140+
* @group legacy
141+
*/
139142
public function testSupportProxy()
140143
{
141144
$em = DoctrineTestHelper::createTestEntityManager();
@@ -202,6 +205,9 @@ public function testPasswordUpgrades()
202205
$provider->upgradePassword($user, 'foobar');
203206
}
204207

208+
/**
209+
* @group legacy
210+
*/
205211
public function testRefreshedUserProxyIsLoaded()
206212
{
207213
$em = DoctrineTestHelper::createTestEntityManager();

Tests/Validator/Constraints/UniqueEntityValidatorTest.php

+3
Original file line numberDiff line numberDiff line change
@@ -223,6 +223,9 @@ public static function provideUniquenessConstraints(): iterable
223223
yield 'Named arguments' => [new UniqueEntity(message: 'myMessage', fields: ['name'], em: 'foo')];
224224
}
225225

226+
/**
227+
* @group legacy
228+
*/
226229
public function testValidateEntityWithPrivatePropertyAndProxyObject()
227230
{
228231
$entity = new SingleIntIdWithPrivateNameEntity(1, 'Foo');

0 commit comments

Comments
 (0)