Merge branch '6.4' into 7.1

* 6.4:
  [DoctrineBridge] Fix the `LockStoreSchemaListener`
  add German translations for the Week constraint messages
  sync Week constraint messages translations
  [Validator] Add `D` regex modifier in relevant validators
  [Validator] Add French translation for the `Week` constraint
  skip transient Redis integration tests on AppVeyor
  reject malformed URLs with a meaningful exception
  [Mime] Add tests on constraints

Author: nicolas-grekas

SchemaListener/LockStoreSchemaListener.php

@@ -12,7 +12,6 @@
 namespace Symfony\Bridge\Doctrine\SchemaListener;
 
 use Doctrine\ORM\Tools\Event\GenerateSchemaEventArgs;
-use Symfony\Component\Lock\Exception\InvalidArgumentException;
 use Symfony\Component\Lock\PersistingStoreInterface;
 use Symfony\Component\Lock\Store\DoctrineDbalStore;
 
@@ -30,20 +29,12 @@ public function postGenerateSchema(GenerateSchemaEventArgs $event): void
     {
         $connection = $event->getEntityManager()->getConnection();
 
-        $storesIterator = new \ArrayIterator($this->stores);
-        while ($storesIterator->valid()) {
-            try {
-                $store = $storesIterator->current();
-                if (!$store instanceof DoctrineDbalStore) {
-                    continue;
-                }
-
-                $store->configureSchema($event->getSchema(), $this->getIsSameDatabaseChecker($connection));
-            } catch (InvalidArgumentException) {
-                // no-op
+        foreach ($this->stores as $store) {
+            if (!$store instanceof DoctrineDbalStore) {
+                continue;
             }
 
-            $storesIterator->next();
+            $store->configureSchema($event->getSchema(), $this->getIsSameDatabaseChecker($connection));
         }
     }
 }

Tests/SchemaListener/LockStoreSchemaListenerTest.php

@@ -17,7 +17,6 @@
 use Doctrine\ORM\Tools\Event\GenerateSchemaEventArgs;
 use PHPUnit\Framework\TestCase;
 use Symfony\Bridge\Doctrine\SchemaListener\LockStoreSchemaListener;
-use Symfony\Component\Lock\Exception\InvalidArgumentException;
 use Symfony\Component\Lock\Store\DoctrineDbalStore;
 
 class LockStoreSchemaListenerTest extends TestCase
@@ -37,23 +36,7 @@ public function testPostGenerateSchemaLockPdo()
             ->method('configureSchema')
             ->with($schema, fn () => true);
 
-        $subscriber = new LockStoreSchemaListener([$lockStore]);
-        $subscriber->postGenerateSchema($event);
-    }
-
-    public function testPostGenerateSchemaWithInvalidLockStore()
-    {
-        $entityManager = $this->createMock(EntityManagerInterface::class);
-        $entityManager->expects($this->once())
-            ->method('getConnection')
-            ->willReturn($this->createMock(Connection::class));
-        $event = new GenerateSchemaEventArgs($entityManager, new Schema());
-
-        $subscriber = new LockStoreSchemaListener((static function (): \Generator {
-            yield $this->createMock(DoctrineDbalStore::class);
-
-            throw new InvalidArgumentException('Unsupported Connection');
-        })());
+        $subscriber = new LockStoreSchemaListener((static fn () => yield $lockStore)());
         $subscriber->postGenerateSchema($event);
     }
 }