Filesystem::touch() not working with different owners (utime/atime issue)

Iltar van der Berg · fabpot · commit ed1e991aa071 · 2013-04-21T09:19:24.000+02:00
diff --git a/Filesystem.php b/Filesystem.php
@@ -100,12 +100,9 @@ public function exists($files)
      */
     public function touch($files, $time = null, $atime = null)
     {
-        if (null === $time) {
-            $time = time();
-        }
-
         foreach ($this->toIterator($files) as $file) {
-            if (true !== @touch($file, $time, $atime)) {
+            $touch = $time ? @touch($file, $time, $atime) : @touch($file);
+            if (true !== $touch) {
                 throw new IOException(sprintf('Failed to touch %s', $file));
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -100,12 +100,9 @@ public function exists($files)`
`100`	`100`	`*/`
`101`	`101`	`public function touch($files, $time = null, $atime = null)`
`102`	`102`	`{`
`103`		`- if (null === $time) {`
`104`		`- $time = time();`
`105`		`- }`
`106`		`-`
`107`	`103`	`foreach ($this->toIterator($files) as $file) {`
`108`		`- if (true !== @touch($file, $time, $atime)) {`
	`104`	`+ $touch = $time ? @touch($file, $time, $atime) : @touch($file);`
	`105`	`+ if (true !== $touch) {`
`109`	`106`	`throw new IOException(sprintf('Failed to touch %s', $file));`
`110`	`107`	`}`
`111`	`108`	`}`