fix(maker): generate validator constraints compatible with Symfony 8

Author: ozhantr

src/Maker/MakeRegistrationForm.php

@@ -559,9 +559,9 @@ private function generateFormClass(ClassNameDetails $userClassDetails, Generator
                 'options_code' => <<<EOF
                                     'mapped' => false,
                                     'constraints' => [
-                                        new IsTrue([
-                                            'message' => 'You should agree to our terms.',
-                                        ]),
+                                        new IsTrue(
+                                            message: 'You should agree to our terms.',
+                                        ),
                                     ],
                     EOF
             ],
@@ -573,15 +573,15 @@ private function generateFormClass(ClassNameDetails $userClassDetails, Generator
                                     'mapped' => false,
                                     'attr' => ['autocomplete' => 'new-password'],
                                     'constraints' => [
-                                        new NotBlank([
-                                            'message' => 'Please enter a password',
-                                        ]),
-                                        new Length([
-                                            'min' => 6,
-                                            'minMessage' => 'Your password should be at least {{ limit }} characters',
+                                        new NotBlank(
+                                            message: 'Please enter a password',
+                                        ),
+                                        new Length(
+                                            min: 6,
+                                            minMessage: 'Your password should be at least {{ limit }} characters',
                                             // max length allowed by Symfony for security reasons
-                                            'max' => 4096,
-                                        ]),
+                                            max: 4096,
+                                        ),
                                     ],
                     EOF
             ],

src/Test/MakerTestEnvironment.php

@@ -163,7 +163,7 @@ public function prepareDirectory(): void
                 $dependencies = $this->determineMissingDependencies();
                 if ($dependencies) {
                     // -v actually silences the "very" verbose output in case of an error
-                    $composerProcess = MakerTestProcess::create(\sprintf('composer require %s -v', implode(' ', $dependencies)), $this->path)
+                    $composerProcess = MakerTestProcess::create(\sprintf('composer require %s -v -W', implode(' ', $dependencies)), $this->path)
                         ->run(true)
                     ;
 

templates/resetPassword/ChangePasswordFormType.tpl.php

@@ -18,15 +18,15 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
                 ],
                 'first_options' => [
                     'constraints' => [
-                        new NotBlank([
-                            'message' => 'Please enter a password',
-                        ]),
-                        new Length([
-                            'min' => 12,
-                            'minMessage' => 'Your password should be at least {{ limit }} characters',
+                        new NotBlank(
+                            message: 'Please enter a password',
+                        ),
+                        new Length(
+                            min: 12,
+                            minMessage: 'Your password should be at least {{ limit }} characters',
                             // max length allowed by Symfony for security reasons
-                            'max' => 4096,
-                        ]),
+                            max: 4096,
+                        ),
                         new PasswordStrength(),
                         new NotCompromisedPassword(),
                     ],

templates/resetPassword/ResetPasswordRequestFormType.tpl.php

@@ -12,9 +12,9 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
             ->add('<?= $email_field ?>', EmailType::class, [
                 'attr' => ['autocomplete' => 'email'],
                 'constraints' => [
-                    new NotBlank([
-                        'message' => 'Please enter your email',
-                    ]),
+                    new NotBlank(
+                        message: 'Please enter your email',
+                    ),
                 ],
             ])
         ;

tests/Doctrine/EntityRegeneratorTest.php

@@ -175,13 +175,12 @@ protected function configureContainer(ContainerBuilder $c, LoaderInterface $load
             ],
         ];
 
-        if (null !== $doctrineBundleVersion = InstalledVersions::getVersion('doctrine/doctrine-bundle')) {
-            if (version_compare($doctrineBundleVersion, '2.8.0', '>=')) {
-                $orm['enable_lazy_ghost_objects'] = true;
-            }
-            if (\PHP_VERSION_ID >= 80400 && version_compare($doctrineBundleVersion, '2.15.0', '>=')) {
-                $orm['enable_native_lazy_objects'] = true;
-            }
+        if (
+            \PHP_VERSION_ID >= 80400
+            && null !== $doctrineBundleVersion = InstalledVersions::getVersion('doctrine/doctrine-bundle')
+            && version_compare($doctrineBundleVersion, '2.15.0', '>=')
+        ) {
+            $orm['enable_native_lazy_objects'] = true;
         }
 
         $c->prependExtensionConfig('doctrine', [

tests/Util/TemplateLinterTest.php

@@ -44,10 +44,14 @@ public function testPhpCsFixerVersion(): void
 
         $fixerPath = \sprintf('%s/src/Resources/bin/php-cs-fixer-v%s.phar', \dirname(__DIR__, 2), TemplateLinter::BUNDLED_PHP_CS_FIXER_VERSION);
 
-        $process = Process::fromShellCommandline(\sprintf('%s -V', $fixerPath));
+        $process = new Process([\PHP_BINARY, $fixerPath, '-V']);
 
         $process->run();
 
+        if (!$process->isSuccessful() || '' === trim($process->getOutput())) {
+            $this->markTestSkipped('php-cs-fixer binary could not be executed in this environment.');
+        }
+
         self::assertStringContainsString(TemplateLinter::BUNDLED_PHP_CS_FIXER_VERSION, $process->getOutput());
     }