Merge branch '6.4' into 7.0

* 6.4: (47 commits)
  Sync .github/expected-missing-return-types.diff
  [FrameworkBundle] Add void return-type to ErrorLoggerCompilerPass
  [DoctrineBridge] Fix cross-versions compat
  [HttpKernel] Handle nullable callback of StreamedResponse
  [Mailer] Capitalize sender header for Mailgun
  [FrameworkBundle] Configure `logger` as error logger if the Monolog Bundle is not registered
  DX: PHP CS Fixer - drop explicit nullable_type_declaration_for_default_null_value config, as it's part of ruleset anyway
  DX: PHP CS Fixer - drop explicit no_superfluous_phpdoc_tags config, as it's part of ruleset already
  [DI] Simplify using DI attributes with `ServiceLocator/Iterator`'s
  [FrameworkBundle] Fix registering workflow.registry
  Revert "Add keyword `dev` to leverage composer hint"
  [Validator] Add missing Ukrainian translations #51960
  [Validator] Add missing translations for Indonesian (id)
  [Validator] Add missing translations for Vietnamese (VI)
  Add missing Validator translations - Croatian (hr)
  [HttpFoundation]  Improve PHPDoc of Cache attribute
  [Validator] Add missing Spanish (es) translations #51956
  [Serializer] Add `XmlEncoder::CDATA_WRAPPING` context option
  [Finder] Add early directory prunning filter support
  Add missing dutch translations
  ...

Author: nicolas-grekas

RawMessage.php

@@ -30,11 +30,13 @@ public function toString(): string
         if (\is_string($this->message)) {
             return $this->message;
         }
-        if ($this->message instanceof \Traversable) {
-            $this->message = iterator_to_array($this->message, false);
+
+        $message = '';
+        foreach ($this->message as $chunk) {
+            $message .= $chunk;
         }
 
-        return $this->message = implode('', $this->message);
+        return $this->message = $message;
     }
 
     public function toIterable(): iterable
@@ -45,12 +47,9 @@ public function toIterable(): iterable
             return;
         }
 
-        $message = '';
         foreach ($this->message as $chunk) {
-            $message .= $chunk;
             yield $chunk;
         }
-        $this->message = $message;
     }
 
     /**

Tests/RawMessageTest.php

@@ -19,36 +19,40 @@ class RawMessageTest extends TestCase
     /**
      * @dataProvider provideMessages
      */
-    public function testToString($messageParameter)
+    public function testToString(mixed $messageParameter, bool $supportReuse)
     {
         $message = new RawMessage($messageParameter);
         $this->assertEquals('some string', $message->toString());
         $this->assertEquals('some string', implode('', iterator_to_array($message->toIterable())));
-        // calling methods more than once work
-        $this->assertEquals('some string', $message->toString());
-        $this->assertEquals('some string', implode('', iterator_to_array($message->toIterable())));
+
+        if ($supportReuse) {
+            // calling methods more than once work
+            $this->assertEquals('some string', $message->toString());
+            $this->assertEquals('some string', implode('', iterator_to_array($message->toIterable())));
+        }
     }
 
-    public static function provideMessages(): array
+    /**
+     * @dataProvider provideMessages
+     */
+    public function testSerialization(mixed $messageParameter, bool $supportReuse)
     {
-        return [
-            'string' => ['some string'],
-            'traversable' => [new \ArrayObject(['some', ' ', 'string'])],
-            'array' => [['some', ' ', 'string']],
-        ];
+        $message = new RawMessage($messageParameter);
+        $this->assertEquals('some string', unserialize(serialize($message))->toString());
+
+        if ($supportReuse) {
+            // calling methods more than once work
+            $this->assertEquals('some string', unserialize(serialize($message))->toString());
+        }
     }
 
-    public function testSerialization()
+    public static function provideMessages(): array
     {
-        $message = new RawMessage('string');
-        $this->assertEquals('string', unserialize(serialize($message))->toString());
-        // calling methods more than once work
-        $this->assertEquals('string', unserialize(serialize($message))->toString());
-
-        $message = new RawMessage(new \ArrayObject(['some', ' ', 'string']));
-        $message = new RawMessage($message->toIterable());
-        $this->assertEquals('some string', unserialize(serialize($message))->toString());
-        // calling methods more than once work
-        $this->assertEquals('some string', unserialize(serialize($message))->toString());
+        return [
+            'string' => ['some string', true],
+            'traversable' => [new \ArrayObject(['some', ' ', 'string']), true],
+            'array' => [['some', ' ', 'string'], true],
+            'generator' => [(function () { yield 'some'; yield ' '; yield 'string'; })(), false],
+        ];
     }
 }