Merge branch '5.4' into 6.0

* 5.4: (31 commits)
  fix test
  Clarify goals of AbstractController
  cs fix
  [Security][Validator] Add missing translations for Indonesian (id)
  [Security] Deprecate legacy signatures
  [Notifier] fix typo firebase
  [SecurityBundle] Create a smooth upgrade path for security factories
  Add trailing Line return if last line is non empty
  Add trailing Line return if last line is non empty
  [Security] Deprecate `PassportInterface`
  Report mismatches between trans-unit id and source text via status script
  Do not add namespace argument to NullAdapter in CachePoolPass
  [FrameworkBundle] Update cache:clear help
  [HttpFoundation] Add `litespeed_finish_request` to `Response`
  Fix markup
  (minor) remove author tags from test classes
  [Notifier] add `SentMessageEvent` and `FailedMessageEvent`
  [HttpFoundation] Mark Request::get() internal
  Add missing to semi-colon to exception.js
  [FrameworkBundle] remove dead conditions in Translation Commands
  ...

Author: chalasr

Crypto/DkimSigner.php

@@ -203,7 +203,13 @@ private function hashBody(AbstractPart $body, string $bodyCanon, int $maxLength)
             hash_update($hash, $canon);
         }
 
-        if (0 === $length) {
+        // Add trailing Line return if last line is non empty
+        if (\strlen($currentLine) > 0) {
+            hash_update($hash, "\r\n");
+            $length += \strlen("\r\n");
+        }
+
+        if (!$relaxed && 0 === $length) {
             hash_update($hash, "\r\n");
             $length = 2;
         }

Tests/Crypto/DkimSignerTest.php

@@ -122,14 +122,14 @@ public function getCanonicalizeHeaderData()
             DkimSigner::CANON_SIMPLE, "\r\n", '', \PHP_INT_MAX,
         ];
         yield 'relaxed_empty' => [
-            DkimSigner::CANON_RELAXED, "\r\n", '', \PHP_INT_MAX,
+            DkimSigner::CANON_RELAXED, '', '', \PHP_INT_MAX,
         ];
 
         yield 'simple_empty_single_ending_CLRF' => [
             DkimSigner::CANON_SIMPLE, "\r\n", "\r\n", \PHP_INT_MAX,
         ];
         yield 'relaxed_empty_single_ending_CLRF' => [
-            DkimSigner::CANON_RELAXED, "\r\n", "\r\n", \PHP_INT_MAX,
+            DkimSigner::CANON_RELAXED, '', "\r\n", \PHP_INT_MAX,
         ];
 
         yield 'simple_multiple_ending_CLRF' => [