Add types to private and internal properties

Author: nicolas-grekas

Part/AbstractMultipartPart.php

@@ -18,8 +18,8 @@
  */
 abstract class AbstractMultipartPart extends AbstractPart
 {
-    private $boundary;
-    private $parts = [];
+    private ?string $boundary = null;
+    private array $parts = [];
 
     public function __construct(AbstractPart ...$parts)
     {

Part/DataPart.php

@@ -20,19 +20,17 @@
 class DataPart extends TextPart
 {
     /** @internal */
-    protected $_parent;
+    protected array $_parent;
 
-    private $filename;
-    private $mediaType;
-    private $cid;
+    private ?string $filename = null;
+    private string $mediaType;
+    private ?string $cid = null;
 
     /**
      * @param resource|string|File $body Use a File instance to defer loading the file until rendering
      */
     public function __construct($body, string $filename = null, string $contentType = null, string $encoding = null)
     {
-        unset($this->_parent);
-
         if ($body instanceof File && !$filename) {
             $filename = $body->getFilename();
         }

Part/File.php

@@ -18,7 +18,7 @@
  */
 class File
 {
-    private static $mimeTypes;
+    private static MimeTypes $mimeTypes;
 
     public function __construct(
         private string $path,

Part/MessagePart.php

@@ -21,7 +21,7 @@
  */
 class MessagePart extends DataPart
 {
-    private $message;
+    private RawMessage $message;
 
     public function __construct(RawMessage $message)
     {

Part/Multipart/FormDataPart.php

@@ -23,7 +23,7 @@
  */
 final class FormDataPart extends AbstractMultipartPart
 {
-    private $fields = [];
+    private array $fields = [];
 
     /**
      * @param array<string|array|DataPart> $fields

Part/Multipart/RelatedPart.php

@@ -19,7 +19,7 @@
  */
 final class RelatedPart extends AbstractMultipartPart
 {
-    private $mainPart;
+    private AbstractPart $mainPart;
 
     public function __construct(AbstractPart $mainPart, AbstractPart $part, AbstractPart ...$parts)
     {

Part/SMimePart.php

@@ -19,17 +19,15 @@
 class SMimePart extends AbstractPart
 {
     /** @internal */
-    protected $_headers;
+    protected Headers $_headers;
 
-    private $body;
-    private $type;
-    private $subtype;
-    private $parameters;
+    private iterable|string $body;
+    private string $type;
+    private string $subtype;
+    private array $parameters;
 
     public function __construct(iterable|string $body, string $type, string $subtype, array $parameters)
     {
-        unset($this->_headers);
-
         parent::__construct();
 
         $this->body = $body;

Part/TextPart.php

@@ -24,28 +24,23 @@
 class TextPart extends AbstractPart
 {
     /** @internal */
-    protected $_headers;
+    protected Headers $_headers;
 
-    private static $encoders = [];
+    private static array $encoders = [];
 
     private $body;
-    private $charset;
-    private $subtype;
-    /**
-     * @var ?string
-     */
-    private $disposition;
-    private $name;
-    private $encoding;
-    private $seekable;
+    private ?string $charset;
+    private string $subtype;
+    private ?string $disposition = null;
+    private ?string $name = null;
+    private string $encoding;
+    private ?bool $seekable = null;
 
     /**
      * @param resource|string|File $body Use a File instance to defer loading the file until rendering
      */
     public function __construct($body, ?string $charset = 'utf-8', string $subtype = 'plain', string $encoding = null)
     {
-        unset($this->_headers);
-
         parent::__construct();
 
         if (!\is_string($body) && !\is_resource($body) && !$body instanceof File) {

RawMessage.php

@@ -18,7 +18,7 @@
  */
 class RawMessage
 {
-    private $message;
+    private iterable|string|null $message = null;
 
     public function __construct(iterable|string $message)
     {